[Bug 249513] Review Request: gnome-sshman - SSH session manager for GNOME

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: gnome-sshman - SSH session manager for GNOME


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=249513


jochen at herr-schmitt.de changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|Review Request: gnome-sshman|Review Request: gnome-sshman
                   |- SSH session manager for   |- SSH session manager for
                   |GNOME                       |GNOME
             Status|NEW                         |NEEDINFO
         AssignedTo|nobody at fedoraproject.org    |jochen at herr-schmitt.de
               Flag|                            |fedora-review-,
                   |                            |needinfo?(adel.gadllah at gmail
                   |                            |.com)




------- Additional Comments From jochen at herr-schmitt.de  2007-07-26 13:18 EST -------
Good:
+ Package meets naming guidelines
+ SPEC file matches with package base name
+ Package has consitant macro usage
+ License is GPL
+ License tag matches with license in upstream tar ball
+ Package contains verbatim copy of the license text
+ SPEC is written in English
+ SPEC is legible
+ Tar ball matches with upstream
  (md5sum: 4a4d64d6064770bc5a914ca47c418c4f)
+ Package contains correct buildroot
+ BuildRequies aren't redundant
+ Packages doesn't contains sub packages
+ Local build works fine
+ Local instal works fine
+ Package contains proper %defattr and file permissions
+ Package contains no duplicate files
+ package contains no file or directories owned by other packes.
+ Package contains correct %clean section
+ buildroot will cleaned in %clean section and at the beginning of the %install
section
+ %doc section is small
+ File in %doc section don't affect runtime
+ Rpmlint is quite on source rpm
+ Rpmlint is quite on binary rpm



Bad:
- When I try to connect to an sshd server, I get only a empty terminal window
after I have type in my ssh passphrase
- Mock build failes. You have to add a BR to desktop-file-utils 



-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.