[Bug 249725] Review Request: bombardier - The GNU bombing utility

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: bombardier - The GNU bombing utility


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=249725





------- Additional Comments From wart at kobold.org  2007-07-26 15:07 EST -------
One possibility to solve the size problem is to change the HEIGHT setting in
values.h from 24 to 23.  The game still seems to play fine with this smaller
setting.

GOOD
====
 * Sources matches upstream:
    1a557bdfc61a7d53963a7637624a99e4  bombardier_0.8.2.2.tar.gz
 * Packages runs without crashing
 * Package named appropriately
 * GPL license ok, license file included
 * Spec file legible and in Am. English
 * Compiles and builds on F7-x86_64
 * No locales
 * No shared libs
 * Not relocatable
 * Does not create directories that it should own
 * No need for -devel or -static subpackages
 * Filenames are UTF-8

MUSTFIX
=======
 * Include the manpage
 * Package does not honor RPM_OPT_FLAGS
 * desktop-file-utils should be part of BuildRequires, not Requires

SHOULD
======
 * Include a .desktop file that launches the game in a terminal window
 * Enable the shared highscore file via a setgid executable.  Ideally this
   highscore file would be moved out of its own directory from
   /var/games/bombardier/bdscore to /var/games/bdscore, but that's just a minor
   nit.

NOTES
=====
 * You can further simplify the %install section by creating the destination
   directory and installing the executable in one step:
   install -pD -m 755 bombardier %{buildroot}%{_bindir}/bombardier

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.