[Bug 249034] Review Request: sundials - nonlinear differential/algebraic solvers from LLNL

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: sundials - nonlinear differential/algebraic solvers from LLNL


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=249034





------- Additional Comments From wolfy at nobugconsulting.ro  2007-07-30 05:17 EST -------
I've taken a look at the spec and had the src.rpm built in mock.
There is a small problem with the Source tag, the URL listed over there
(http://ascend.cheme.cmu.edu/ftp/sundials-2.3.0.tar.gz) is not reachable. And it
is not the link provided by upstream. The fact that one has to actually agree to
the BSD license and provide a username+email address before using
http://www.llnl.gov/casc/sundials/download/download.html for downloading the
source is a bit of nuisance, but I would still use this URL as Source0 rather
then a copy placed somewhere else.

Minor problems which you might want to fix before uploading to cvs
- autoconf is already a BR of automake
- rpmlint on the source rpm gives:Source RPM:
W: sundials macro-in-%changelog configure
W: sundials mixed-use-of-spaces-and-tabs (spaces: line 11, tab: line 1)
These are easy to fix, just replace '%configure' with '%%configure' in changelog
and stick with either tabs or spaces in the spec.

 rpmlint sundials-devel-2.3.0-2.fc8.x86_64.rpm gives
W: sundials-devel no-documentation
which can be ignored, since we have a separate -doc rpm.

Looking at the mock build log, the flags used during compile seem OK to me.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.