[Bug 239385] Review Request: peless - Text Browser

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: peless - Text Browser


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=239385


mtasaka at ioa.s.u-tokyo.ac.jp changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|nobody at fedoraproject.org    |mtasaka at ioa.s.u-tokyo.ac.jp
               Flag|                            |fedora-review?




------- Additional Comments From mtasaka at ioa.s.u-tokyo.ac.jp  2007-07-31 11:52 EST -------
Much better!!
For -2:
* Desktop file
  - Catetory "Application" is deprecated and should be removed
    (use --remove-category Application)
  - Use fedora as vendir_id. i.e.
    desktop-file-install --vendor fedora ....
    and this will create fedora-peless.desktop (and this case,
    use "--remove-original": please check the section
    "Desktop files" of
    http://fedoraproject.org/wiki/Packaging/Guidelines )
* Packager/URL
  - Please remove the line "Packager". This is automatically set on
    Fedora side
  - And use https://developer.berlios.de/projects/peless/ as URL.
* Documents
  - Why do you want to include philo.txt as documents?
* Changelog
  - Please also add the EVR (Epoch-Version-Release) 
    to %changelog entry. For example:
--------------------------------------------------------------------
* Sat Jul 28 2007 Paul Elliott <pelliott at io.com> - 1.156-2
- implement changes requested by Mamoru Tasaka    on 2007-07-26
--------------------------------------------------------------------

Okay, this package will be (almost?) okay if you fix the issues
above. However, as this is a sponsor requested ticket, please
read below:
--------------------------------------------------------------------
NOTE: Before being sponsored:

This package will be accepted with another few work. 
But before I accept this package, someone (I am a candidate) 
must sponsor you.

Once you are sponsored, you have the right to review other 
submitters' review requests and approve the packages formally. 
For this reason, the person who want to be sponsored (like you) 
are required to "show that you have an understanding 
of the process and of the packaging guidelines" as is described
on :
http://fedoraproject.org/wiki/PackageMaintainers/HowToGetSponsored

Usually there are two ways to show this.
A. submit other review requests with enough quality.
B. Do a "pre-review" of other person's review request
   (at the time you are not sponsored, you cannot do
   a formal review)

When you have submitted a new review request or have pre-reviewed other 
person's review request, please write the bug number on this bug report 
so that I can check your comments or review request.

Fedora package collection review requests which are waiting for someone to
review can be checked on:
http://fedoraproject.org/PackageReviewStatus/NEW.html
(NOTE: please don't choose "Merge Review")


Review guidelines are described mainly on:
http://fedoraproject.org/wiki/Packaging/ReviewGuidelines
http://fedoraproject.org/wiki/Packaging/Guidelines
http://fedoraproject.org/wiki/Packaging/ScriptletSnippets
------------------------------------------------------------

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.