[Bug 246150] Package Review: dynamips - Powerful Cisco IOS Emulator/Hypervisor

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Package Review: dynamips - Powerful Cisco IOS Emulator/Hypervisor


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=246150





------- Additional Comments From pingoufc4 at yahoo.fr  2007-07-31 17:37 EST -------
Hi

>MUST: rpmlint must be run on every package. The output should be posted in the
review.
$ rpmlint ../SRPMS/dynamips-0.2.7-1.fc6.src.rpm
../RPMS/i386/dynamips-0.2.7-1.fc6.i386.rpm
../RPMS/i386/dynamips-debuginfo-0.2.7-1.fc6.i386.rpm
=> clean

>MUST: The package must be named according to the Package Naming Guidelines.
Ok

>MUST: The spec file name must match the base package %{name}, in the format
%{name}.spec unless your package has an exemption on  Package Naming Guidelines. 
Ok

>MUST: The package must meet the  Packaging Guidelines.
License Text => absent whereas the COPYING is present in the original tarball
(I think README can also be included)

>MUST: The package must be licensed with an open-source compatible license and
meet other legal requirements as defined in the legal section of Packaging
Guidelines.
Ok

>MUST: The License field in the package spec file must match the actual license.
Ok

>MUST: If (and only if) the source package includes the text of the license(s)
in its own file, then that file, containing the text of the license(s) for the
package must be included in %doc
No (see above)

>MUST: The spec file must be written in American English
Ok

>MUST: The spec file for the package MUST be legible. If the reviewer is unable
to read the spec file, it will be impossible to perform a review.
Ok

>MUST: The sources used to build the package must match the upstream source, as
provided in the spec URL.
Ok

>MUST: The package must successfully compile and build into binary rpms on at
least one supported architecture.
Built Ok on i386

>MUST: All build dependencies must be listed in BuildRequires
Ok

>MUST: The spec file MUST handle locales properly. 
There is no so
Ok

>MUST: Every binary RPM package which stores shared library files (not just
symlinks) in any of the dynamic linker's default paths, must call ldconfig in
%post and %postun. 
Ok

>MUST: If the package is designed to be relocatable, the packager must state
this fact in the request for review, along with the rationalization for
relocation of that specific package.
Ok

>MUST: A package must own all directories that it creates.
I would prefer a more detailled one [ie {%_mandir}/man1/ is not owned by the
software as it contains other files (that would lead to a confusion on rpm -qf I
think)]
%{_bindir}/%{name}
%{_bindir}/nvram_export   
%{_mandir}/man1/%{name}.1.gz
%{_mandir}/man1/nvram_export.1.gz
%{_mandir}/man7/hypervisor_mode.7.gz

>MUST: A package must not contain any duplicate files in the %files listing.
Ok

>MUST: Permissions on files must be set properly. Executables should be set with
executable permissions, for example. Every %files section must include a
%defattr(...) line.
Ok

>MUST: Each package must have a %clean section, which contains rm -rf
%{buildroot} (or $RPM_BUILD_ROOT).
Ok

>MUST: Each package must consistently use macros, as described in the macros
section of Packaging Guidelines. 
Ok

>MUST: The package must contain code, or permissable content. This is described
in detail in the code vs. content section of Packaging Guidelines. 
Ok

>MUST: Large documentation files should go in a -doc subpackage.
Ok

>MUST: If a package includes something as %doc, it must not affect the runtime
of the application. 
Ok

>MUST: Header files must be in a -devel package
Ok

>MUST: Static libraries must be in a -static package.
Ok

>MUST: Packages containing pkgconfig(.pc) files must 'Requires: pkgconfig' (for
directory ownership and usability)
Ok

>MUST: If a package contains library files with a suffix (e.g. libfoo.so.1.1),
then library files that end in .so (without suffix) must go in a -devel package.
Ok

>MUST: In the vast majority of cases, devel packages must require the base
package using a fully versioned dependency: Requires: %{name} =
%{version}-%{release} 
Ok

>MUST: Packages must NOT contain any .la libtool archives, these should be
removed in the spec.
Ok

>MUST: Packages containing GUI applications must include a %{name}.desktop file,
and that file must be properly installed with desktop-file-install in the
%install section. 
Ok

>MUST: Packages must not own files or directories already owned by other packages.
This is why I would prefer a more detailed %files section

>MUST: At the beginning of %install, each package MUST run rm -rf %{buildroot}
(or $RPM_BUILD_ROOT)
Ok

>MUST: All filenames in rpm packages must be valid UTF-8.
Ok

I did not find any big issue with the SHOULD condition.
Regards,
P.Y.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.