[Bug 241978] Review Request: tig - Text-mode interface for git

bugzilla at redhat.com bugzilla at redhat.com
Fri Jun 1 15:35:56 UTC 2007


Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: tig - Text-mode interface for git


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=241978





------- Additional Comments From jeff at ocjtech.us  2007-06-01 11:35 EST -------
A few of things that I did in my spec (none of them blockers):

1. Build the HTML documentation and list them in %doc.  After they are built
you'll need to convert CRLF line endings to LF line endings.

2. Include the manual.txt in %doc.

3. Added -DVERSION\\\"%{version}-%{release}\\\" to the CFLAGS.  That way tig
will print the rpm release when you type "tig --version".  Could help with
debugging down the road...

4. Use %{_mandir} and %{_prefix} instead of hard-coded paths in the "make
install" line.

Otherwise my spec and your spec are nearly identical.  Feel free to list me as a
co-maintainer once the package is approved.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.




More information about the Fedora-package-review mailing list