[Bug 223422] Review Request: mrxvt - Multi-tabbed terminal emulator.

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: mrxvt - Multi-tabbed terminal emulator.


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=223422





------- Additional Comments From mtasaka at ioa.s.u-tokyo.ac.jp  2007-06-04 12:23 EST -------
(In reply to comment #19)
> 1)Source URL -- FIXED
> 2)Directory Ownership -- FIXED
Okay.

> 3)Documentation -- NOT FIXED 
For this, please once remove all files under 
%{_datadir}/doc/%{name} by:
-----------------------------------------------
%install
rm -rf $RPM_BUILD_ROOT
make DESTDIR=$RPM_BUILD_ROOT INSTALL="%{__install} -p" install 

desktop-file-install --vendor=fedora \
        --dir=$RPM_BUILD_ROOT%{_datadir}/applications \
        %{SOURCE1}

rm -rf $RPM_BUILD_ROOT%{_datadir}/doc
------------------------------------------------
  and later add the proper documents by:
------------------------------------------------
%files
%defattr(-,root,root,-)
%doc doc/README* doc/*.txt*
%doc share/scripts/
%doc AUTHORS ChangeLog COPYING NEWS README TODO
------------------------------------------------
Here two modification is added:
* Timestamps
  - This installs some text/image files which are not modified
    or created during build stage and keeping timestamps on
    these files is recommended.
    For this package, this can be done by adding 
    'INSTALL=%{__install} -p'

* Unneeded documents
  - "INSTALL" file is for people who wants to rebuild this
    by themselves and so it is not needed for rpm file.

> 4)Unneeded Macros -- FIXED
> 5)Changelog Formats -- FIXED
  - Well, please write a bit more precisely.. not just
    "updated spec file"...

(In reply to comment #20)
> One more thing, the reccomendation of integer + %{?dist} fails on rpmbuild,
> which is why I did what I did in the spec file for the Release tag.

- What do you mean by this?
  Usually release number should be:
-----------------------------------------------
Release: 2%{?dist}
-----------------------------------------------
  and the corresponding %changelog entry is:
-----------------------------------------------
* Sun Jun 3 2007 Adam M. Dutko <gnome at dux-linux org> - 0.5.2-2
- <some description>
------------------------------------------------



-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.