[Bug 241099] Review Request: lcdtest - utility to display monitor test patterns

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: lcdtest - utility to display monitor test patterns


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=241099





------- Additional Comments From mtasaka at ioa.s.u-tokyo.ac.jp  2007-06-05 13:11 EST -------
Some quick notes:

* Disttag
  - Adding %{?dist} to release number is recommended
    for easier maintainence on different branches.
    http://fedoraproject.org/wiki/Packaging/DistTag

* Unneeded Requires:
---------------------------------------------------
Requires:	SDL, SDL_image
---------------------------------------------------
  - This is unnessary (and *should not* needed) as rpmbuild
    checks libraries' dependency and automatically adds them
    to Requires.

* Unneeded macros
-----------------------------------------------------
%define _prefix    /usr
%define _bindir    %{_prefix}/bin
%define _mandir    %{_prefix}/share/man
------------------------------------------------------
  - These macros are already defined and are not needed.

* And read the comment 4 by wolfshant-san.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.