[Bug 242566] Review Request: cegui (0.5.x branch) - Free library providing windowing and widgets for graphics APIs / engines

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: cegui (0.5.x branch) - Free library providing windowing and widgets for graphics APIs / engines


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=242566





------- Additional Comments From packages at amiga-hardware.com  2007-06-10 18:38 EST -------
(In reply to comment #4)
> Yes, you have to run rpmlint against the installed packages.  I install all of
> the packages I test (into the mock chroot, a convenient hack) and run rpmlint on

Yeah I knew you could use rpmlint against installed packages, but it never
occurred to me that certain issues can only be picked up this way, I'd just
assumed it was for convenience. =)

Ok, well I've done a bit of research and this is how things stand. Neither
undefined-non-weak-symbol or unused-direct-shlib-dependency are considered blockers.

The first warning is caused by a library/exe not being explicitly linked with a
library that contains those symbols. Sometimes that's actually desirable eg in
the case where you have two libraries which provide a compatible ABI but their
functionality may be different you can use either one, but generally it isn't.
The peformance penalty for this tends to be a slightly longer startup time as
the linker has to locate and satisfy those symbols.

The second is caused by a library/exe being linked with a library for which it
has no need to be. In other words, it's been linked with a library it doesn't
use. I couldn't really find any useful pointers on this one which was quite
surprising seeing as how many libraries in Fedora also have this issue. The
penalty for this tends to be slightly bigger files and perhaps slightly more
memory usage but we're only talking in the region of a few K at most. In order
to try and fix this I tried to make use of the linker option "--as-needed" which
I couldn't get to work. Additionally there's a good gentoo article on this issue
(http://www.gentoo.org/proj/en/qa/asneeded.xml#doc_chap2) which explains you can
often do more harm than good. Lastly it's not always possible for a build system
to determine exactly which libraries it shouldn't link, particularly when
querying .pc files etc. 

So in summary... the weak symbols issue has been fixed. The
unused-direct-shlib-dependency hasn't because I don't feel it can fixed in any
reasonable manner. Of course I completely happy to be proved wrong. Anyway,
here's the latest version:


Spec URL: http://dribble.org.uk/reviews/cegui-0.5.0b-2.src.rpm
SRPM URL: http://dribble.org.uk/reviews/cegui.spec

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.