[Bug 243669] Review Request: pfqueue - Queue manager for the Postfix/Exim Mail Transport Agents

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: pfqueue - Queue manager for the Postfix/Exim Mail Transport Agents


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=243669


wolfy at nobugconsulting.ro changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|fedora-review?              |fedora-review+




------- Additional Comments From wolfy at nobugconsulting.ro  2007-06-13 10:19 EST -------
Package Review
==============

Key:
 - = N/A
 x = Check
 ! = Problem
 ? = Not evaluated

=== REQUIRED ITEMS ===
 [x] Package is named according to the Package Naming Guidelines.
 [x] Spec file name must match the base package %{name}, in the format %{name}.spec.
 [!] Package meets the Packaging Guidelines.
Release tag must be changed (.mf dropped)
 [x] Package successfully compiles and builds into binary rpms on at least one
supported architecture.
     Tested on:FC6 & devel, x86_64 and Centos4/i386
 [x] Rpmlint output:
W: pfqueue devel-file-in-non-devel-package /usr/lib64/libpfq_exim.so
W: pfqueue devel-file-in-non-devel-package /usr/lib64/libpfqueue.so
W: pfqueue devel-file-in-non-devel-package /usr/lib64/libpfq_postfix2.so
W: pfqueue devel-file-in-non-devel-package /usr/lib64/libpfq_socket.so
W: pfqueue devel-file-in-non-devel-package /usr/lib64/libpfq_postfix1.so
All these can be ignored, the files are not devel libs but dlopened at runtime.
Since they are small, there is no point in separating -exim and -postfix files
 [x] Package is not relocatable.
 [x] Buildroot is correct
(%{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n))
 [x] Package is licensed with an open-source compatible license and meets other
legal requirements as defined in the legal section of Packaging Guidelines.
 [x] License field in the package spec file matches the actual license.
     License type:GPL
 [x] If (and only if) the source package includes the text of the license(s) in
its own file, then that file, containing the text of the license(s) for the
package is included in %doc.
 [x] Spec file is legible and written in American English.
 [x] Sources used to build the package matches the upstream source, as provided
in the spec URL.
     SHA1SUM of package: 29fc58eab31b1a6225bda1205f155ed5cfb951b2 
pfqueue-0.5.6.tar.gz
 [x] Package is not known to require ExcludeArch, OR:
     Arches excluded:
     Why:
 [x] All build dependencies are listed in BuildRequires, except for any that are
listed in the exceptions section of Packaging Guidelines.
 [-] The spec file handles locales properly.
 [x] ldconfig called in %post and %postun if required.
 [x] Package must own all directories that it creates.
 [-] Package requires other packages for directories it uses.
 [x] Package does not contain duplicates in %files.
 [x] Permissions on files are set properly.
 [x] Package has a %clean section, which contains rm -rf %{buildroot} (or
$RPM_BUILD_ROOT).
 [x] Package consistently uses macros.
 [x] Package contains code, or permissable content.
 [-] Large documentation files are in a -doc subpackage, if required.
 [x] Package uses nothing in %doc for runtime.
 [-] Header files in -devel subpackage, if present.
 [-] Static libraries in -devel subpackage, if present.
 [-] Package requires pkgconfig, if .pc files are present.
 [-] Development .so files in -devel subpackage, if present.
 [-] Fully versioned dependency in subpackages, if present.
 [x] Package does not contain any libtool archives (.la).
 [-] Package contains a properly installed %{name}.desktop file if it is a GUI
application.
 [x] Package does not own files or directories owned by other packages.

=== SUGGESTED ITEMS ===
 [x] Latest version is packaged.
 [x] Package does not include license text files separate from upstream.
 [-] Description and summary sections in the package spec file contains
translations for supported Non-English languages, if available.
 [x] Reviewer should test that the package builds in mock.
     Tested on: Centos/i386, FC6/x86_64, devel/x86_64
 [x] Package should compile and build into binary rpms on all supported
architectures.
     Tested on: Centos/i386, FC6/x86_64, devel/x86_64
 [x] Package functions as described.
 [-] Scriptlets must be sane, if used.
 [-] The placement of pkgconfig(.pc) files are correct.
 [x] File based requires are sane.

=== Issues ===
1. Source tag should be changed to the more reliable
http://downloads.sourceforge.net/pfqueue/%{name}-%{version}.tar.gz. The one
currently used consistently fails for me
2. The ".mf" part of the release tag should be removed
3. Please drop the INSTALL file from %doc. It contains generic installation
instructions which are useless for those using the binary rpm

=== Final Notes ===
1.


================
*** APPROVED ***
================



-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.