[Bug 235501] Review Request: jsdoc - Produces javadoc-style documentation from JavaScript sourcefiles

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: jsdoc - Produces javadoc-style documentation from JavaScript sourcefiles


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=235501


bugzilla at redhat.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Product|Fedora Extras               |Fedora




------- Additional Comments From lxtnow at gmail.com  2007-06-18 20:10 EST -------
Well,

 [ OK ]     Mock built on x86_64 (F-7 and devel)
 [ FAILED ] Package is named according to the Package Naming Guidelines.
 [ FAILED ] Spec file name must match the base package %{name}.
 [ OK ]     Package meets the Packaging Guidelines.
 [ OK ]     Buildroot is correct (nothing to do).
 [ OK ]     Package is licensed with an open-source compatible license.
 [ ? ]      License field in the package spec file matches the actual license.
 [ ? ]      License type: GPL
 [ FAILED ] License text is included in the package or If (and only if)the
license is containing the text of the license(s) for the package is included in
%doc.

 [ OK ]     Spec file is legible and written in American English.
 [ OK ]     Package has not binaries files and set to noarch package.
 [ OK ]     BuildRequires aren't redundant (unneeded for this package).
 [ OK ]     The spec file handles locales properly.
 [ OK ]     Package must own all directories that it creates.
 [ OK ]     Package requires other packages for directories it uses.
 [ Ok ]     Package does not contain duplicates in %files.
 [ FAILED ] Permissions on files are set properly.
 [ OK ]     Package has a %clean section.
 [ Ok ]     Package consistently uses macros.
 [ OK ]     Package contains code, or permissable content.
 [ OK ]     Package does not contain any libtool archives (.la).
 [ FAILED ] Package does not own files or directories owned by other packages.


== Rpmlint output: ==

 [ OK ]     From SRPM: silent.
 [ FAILED ] From RPM:

E: jsdoc script-without-shebang /usr/share/jsdoc/index.tmpl
E: jsdoc script-without-shebang /usr/lib/perl5/vendor_perl/5.8.8/JSDoc.pm
E: jsdoc script-without-shebang /usr/lib/perl5/vendor_perl/5.8.8/JSDoc/xmi.tmpl
E: jsdoc script-without-shebang /usr/lib/perl5/vendor_perl/5.8.8/JSDoc/XML.pm
E: jsdoc script-without-shebang /usr/share/jsdoc/allclasses-noframe.tmpl
E: jsdoc script-without-shebang /usr/share/jsdoc/overview-frame.tmpl
E: jsdoc script-without-shebang
/usr/lib/perl5/vendor_perl/5.8.8/JavaScript/Syntax/HTML.pm
E: jsdoc script-without-shebang /usr/share/jsdoc/allclasses-frame.tmpl
E: jsdoc script-without-shebang /usr/share/jsdoc/overview-summary.tmpl
E: jsdoc script-without-shebang /usr/share/jsdoc/main.tmpl
E: jsdoc script-without-shebang /usr/share/jsdoc/help-doc.tmpl
E: jsdoc script-without-shebang /usr/share/jsdoc/overview-tree.tmpl
E: jsdoc wrong-script-end-of-line-encoding /usr/share/jsdoc/overview-tree.tmpl
E: jsdoc script-without-shebang /usr/share/jsdoc/stylesheet.css
E: jsdoc script-without-shebang /usr/share/jsdoc/constant-values.tmpl
E: jsdoc script-without-shebang /usr/lib/perl5/vendor_perl/5.8.8/JSDoc/xml.tmpl
E: jsdoc script-without-shebang /usr/share/jsdoc/index-all.tmpl
E: jsdoc script-without-shebang /usr/lib/perl5/vendor_perl/5.8.8/JSDoc/XMI.pm




=== Issues ===

* Your package name SHOULD match the base package name which is JSDoc (with
upperCase letters).
So move your package name from jsdoc to JSDoc.
Also your spec file name.

* The license text seem not added in package and not included in other text file
which are included in the package.

* From %install stage:
Permission on files actually not correctly set for script files (see rpmlint
output above).
Also keep time stamps on docs files.

* From %files section
Your installed directory "%{perl_vendorlib}"is not good, cause your package own
other directories owned by orther installed packages which already owned them.
So your installed path should looks like this:

%{perl_vendorlib}/JSDoc
%{perl_vendorlib}/JavaScript
instead of
%{perl_vendorlib}/*

* rpmlint:
If your files plan/are exacutable scripts, add shebang to the script otherwise
remove executable from these files.
.pm and .tpml files  no need to be executable.

===================================



-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.