[Bug 225826] Merge Review: gnome-netstatus

bugzilla at redhat.com bugzilla at redhat.com
Tue Jun 19 20:14:19 UTC 2007 

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Merge Review: gnome-netstatus


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=225826


bugzilla at redhat.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Product|Fedora Extras               |Fedora

dakingun at gmail.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|fedora-review?              |fedora-review+




------- Additional Comments From dakingun at gmail.com  2007-06-19 16:14 EST -------
I'm sorry for the stalled review, I'd thought it was resolved.

GOOD:
 * Build Ok in mock (x86_64)
 * License (GPL) and rpm Group tag OK
 * Naming meets the packaging guildlines
 * Spec file clean and legible
 * Handles locales correctly
 * Build dependencies properly listed
 * Source file matches upstream's
[deji at agape reviews]$ md5sum gnome-netstatus-2.12.1.tar.bz2 
8651ca1694a6c222ae5cad6e21814d24  gnome-netstatus-2.12.1.tar.bz2
 * Own its files and directories correctly.
 * No rpmlint error/warning on the srpm. 

rmplint however gave a long list of (similar) warnings [1] on the binary; I'm
sure you'll fix that later.

APPROVED.

[1]. rpmlint warnings;
[deji at agape reviews]$ rpmlint gnome-netstatus-2.12.1-1.fc8.x86_64.rpm
W: gnome-netstatus symlink-should-be-relative
/usr/share/gnome/help/gnome-netstatus/ko/figures/gnome-netstatus-tx.png
/usr/share/icons/hicolor/48x48/apps/gnome-netstatus-tx.png
W: gnome-netstatus symlink-should-be-relative
/usr/share/gnome/help/gnome-netstatus/zh_CN/figures/gnome-netstatus-txrx.png
/usr/share/icons/hicolor/48x48/apps/gnome-netstatus-txrx.png
W: gnome-netstatus symlink-should-be-relative
/usr/share/gnome/help/gnome-netstatus/it/figures/gnome-netstatus-error.png
/usr/share/icons/hicolor/48x48/apps/gnome-netstatus-error.png
W: gnome-netstatus symlink-should-be-relative
/usr/share/gnome/help/gnome-netstatus/zh_TW/figures/gnome-netstatus-idle.png
/usr/share/icons/hicolor/48x48/apps/gnome-netstatus-idle.png
W: gnome-netstatus symlink-should-be-relative
/usr/share/gnome/help/gnome-netstatus/ja/figures/gnome-netstatus-rx.png
/usr/share/icons/hicolor/48x48/apps/gnome-netstatus-rx.png
W: gnome-netstatus symlink-should-be-relative
/usr/share/gnome/help/gnome-netstatus/zh_HK/figures/gnome-netstatus-rx.png
/usr/share/icons/hicolor/48x48/apps/gnome-netstatus-rx.png
W: gnome-netstatus symlink-should-be-relative
/usr/share/gnome/help/gnome-netstatus/zh_CN/figures/gnome-netstatus-rx.png
/usr/share/icons/hicolor/48x48/apps/gnome-netstatus-rx.png
W: gnome-netstatus symlink-should-be-relative
/usr/share/gnome/help/gnome-netstatus/de/figures/gnome-netstatus-idle.png
/usr/share/icons/hicolor/48x48/apps/gnome-netstatus-idle.png
W: gnome-netstatus symlink-should-be-relative
/usr/share/gnome/help/gnome-netstatus/zh_TW/figures/gnome-netstatus-disconn.png
/usr/share/icons/hicolor/48x48/apps/gnome-netstatus-disconn.png
W: gnome-netstatus symlink-should-be-relative
/usr/share/gnome/help/gnome-netstatus/it/figures/gnome-netstatus-idle.png
/usr/share/icons/hicolor/48x48/apps/gnome-netstatus-idle.png
W: gnome-netstatus symlink-should-be-relative
/usr/share/gnome/help/gnome-netstatus/zh_HK/figures/gnome-netstatus-tx.png
/usr/share/icons/hicolor/48x48/apps/gnome-netstatus-tx.png
W: gnome-netstatus symlink-should-be-relative
/usr/share/gnome/help/gnome-netstatus/de/figures/gnome-netstatus-txrx.png
/usr/share/icons/hicolor/48x48/apps/gnome-netstatus-txrx.png
W: gnome-netstatus symlink-should-be-relative
/usr/share/gnome/help/gnome-netstatus/zh_HK/figures/gnome-netstatus-error.png
/usr/share/icons/hicolor/48x48/apps/gnome-netstatus-error.png
W: gnome-netstatus symlink-should-be-relative
/usr/share/gnome/help/gnome-netstatus/ko/figures/gnome-netstatus-disconn.png
/usr/share/icons/hicolor/48x48/apps/gnome-netstatus-disconn.png
W: gnome-netstatus symlink-should-be-relative
/usr/share/gnome/help/gnome-netstatus/ja/figures/gnome-netstatus-tx.png
/usr/share/icons/hicolor/48x48/apps/gnome-netstatus-tx.png
W: gnome-netstatus symlink-should-be-relative
/usr/share/gnome/help/gnome-netstatus/de/figures/gnome-netstatus-tx.png
/usr/share/icons/hicolor/48x48/apps/gnome-netstatus-tx.png
W: gnome-netstatus symlink-should-be-relative
/usr/share/gnome/help/gnome-netstatus/zh_CN/figures/gnome-netstatus-disconn.png
/usr/share/icons/hicolor/48x48/apps/gnome-netstatus-disconn.png
W: gnome-netstatus symlink-should-be-relative
/usr/share/gnome/help/gnome-netstatus/it/figures/gnome-netstatus-rx.png
/usr/share/icons/hicolor/48x48/apps/gnome-netstatus-rx.png
W: gnome-netstatus symlink-should-be-relative
/usr/share/gnome/help/gnome-netstatus/ko/figures/gnome-netstatus-error.png
/usr/share/icons/hicolor/48x48/apps/gnome-netstatus-error.png
W: gnome-netstatus symlink-should-be-relative
/usr/share/gnome/help/gnome-netstatus/it/figures/gnome-netstatus-tx.png
/usr/share/icons/hicolor/48x48/apps/gnome-netstatus-tx.png
W: gnome-netstatus symlink-should-be-relative
/usr/share/gnome/help/gnome-netstatus/ko/figures/gnome-netstatus-rx.png
/usr/share/icons/hicolor/48x48/apps/gnome-netstatus-rx.png
W: gnome-netstatus symlink-should-be-relative
/usr/share/gnome/help/gnome-netstatus/zh_CN/figures/gnome-netstatus-tx.png
/usr/share/icons/hicolor/48x48/apps/gnome-netstatus-tx.png
W: gnome-netstatus symlink-should-be-relative
/usr/share/gnome/help/gnome-netstatus/ja/figures/gnome-netstatus-txrx.png
/usr/share/icons/hicolor/48x48/apps/gnome-netstatus-txrx.png
W: gnome-netstatus symlink-should-be-relative
/usr/share/gnome/help/gnome-netstatus/it/figures/gnome-netstatus-txrx.png
/usr/share/icons/hicolor/48x48/apps/gnome-netstatus-txrx.png
W: gnome-netstatus symlink-should-be-relative
/usr/share/gnome/help/gnome-netstatus/de/figures/gnome-netstatus-rx.png
/usr/share/icons/hicolor/48x48/apps/gnome-netstatus-rx.png
W: gnome-netstatus symlink-should-be-relative
/usr/share/gnome/help/gnome-netstatus/zh_TW/figures/gnome-netstatus-rx.png
/usr/share/icons/hicolor/48x48/apps/gnome-netstatus-rx.png
W: gnome-netstatus symlink-should-be-relative
/usr/share/gnome/help/gnome-netstatus/zh_TW/figures/gnome-netstatus-txrx.png
/usr/share/icons/hicolor/48x48/apps/gnome-netstatus-txrx.png
W: gnome-netstatus symlink-should-be-relative
/usr/share/gnome/help/gnome-netstatus/ja/figures/gnome-netstatus-idle.png
/usr/share/icons/hicolor/48x48/apps/gnome-netstatus-idle.png
W: gnome-netstatus symlink-should-be-relative
/usr/share/gnome/help/gnome-netstatus/zh_HK/figures/gnome-netstatus-disconn.png
/usr/share/icons/hicolor/48x48/apps/gnome-netstatus-disconn.png
W: gnome-netstatus symlink-should-be-relative
/usr/share/gnome/help/gnome-netstatus/de/figures/gnome-netstatus-disconn.png
/usr/share/icons/hicolor/48x48/apps/gnome-netstatus-disconn.png
W: gnome-netstatus symlink-should-be-relative
/usr/share/gnome/help/gnome-netstatus/zh_CN/figures/gnome-netstatus-error.png
/usr/share/icons/hicolor/48x48/apps/gnome-netstatus-error.png
W: gnome-netstatus symlink-should-be-relative
/usr/share/gnome/help/gnome-netstatus/it/figures/gnome-netstatus-disconn.png
/usr/share/icons/hicolor/48x48/apps/gnome-netstatus-disconn.png
W: gnome-netstatus symlink-should-be-relative
/usr/share/gnome/help/gnome-netstatus/ko/figures/gnome-netstatus-txrx.png
/usr/share/icons/hicolor/48x48/apps/gnome-netstatus-txrx.png
W: gnome-netstatus non-conffile-in-etc /etc/gconf/schemas/netstatus.schemas
W: gnome-netstatus symlink-should-be-relative
/usr/share/gnome/help/gnome-netstatus/zh_HK/figures/gnome-netstatus-idle.png
/usr/share/icons/hicolor/48x48/apps/gnome-netstatus-idle.png
W: gnome-netstatus symlink-should-be-relative
/usr/share/gnome/help/gnome-netstatus/zh_CN/figures/gnome-netstatus-idle.png
/usr/share/icons/hicolor/48x48/apps/gnome-netstatus-idle.png
W: gnome-netstatus symlink-should-be-relative
/usr/share/gnome/help/gnome-netstatus/ja/figures/gnome-netstatus-disconn.png
/usr/share/icons/hicolor/48x48/apps/gnome-netstatus-disconn.png
W: gnome-netstatus symlink-should-be-relative
/usr/share/gnome/help/gnome-netstatus/zh_TW/figures/gnome-netstatus-tx.png
/usr/share/icons/hicolor/48x48/apps/gnome-netstatus-tx.png
W: gnome-netstatus symlink-should-be-relative
/usr/share/gnome/help/gnome-netstatus/ja/figures/gnome-netstatus-error.png
/usr/share/icons/hicolor/48x48/apps/gnome-netstatus-error.png
W: gnome-netstatus symlink-should-be-relative
/usr/share/gnome/help/gnome-netstatus/de/figures/gnome-netstatus-error.png
/usr/share/icons/hicolor/48x48/apps/gnome-netstatus-error.png
W: gnome-netstatus symlink-should-be-relative
/usr/share/gnome/help/gnome-netstatus/zh_TW/figures/gnome-netstatus-error.png
/usr/share/icons/hicolor/48x48/apps/gnome-netstatus-error.png
W: gnome-netstatus symlink-should-be-relative
/usr/share/gnome/help/gnome-netstatus/ko/figures/gnome-netstatus-idle.png
/usr/share/icons/hicolor/48x48/apps/gnome-netstatus-idle.png
W: gnome-netstatus symlink-should-be-relative
/usr/share/gnome/help/gnome-netstatus/zh_HK/figures/gnome-netstatus-txrx.png
/usr/share/icons/hicolor/48x48/apps/gnome-netstatus-txrx.png

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.

More information about the Fedora-package-review mailing list