[Bug 188138] Review Request: mod_auth_ntlm_winbind - NTLM authentication for the Apache web server using winbind daemon

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: mod_auth_ntlm_winbind - NTLM authentication for the Apache web server using winbind daemon


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=188138





------- Additional Comments From dmitry at butskoy.name  2007-06-20 09:19 EST -------
> The URL: seems to be invalid.
Yep, fixed.

> mixed-use-of-spaces-and-tabs
Prefer a more clean text in files rather then such a kind of pedantic :)
> filename-too-long-for-joliet
Never see it... Assume it will not actually affect debuginfo sub-package in the
final repository.

> "svn export" instead of "svn co"
Done, thanks.
> You need a Requires(post): /usr/sbin/usermod (or shadow-utils).
Add "Rrequires(post): shadow-utils"
> not sure if rpm will guarantee that apache is installed before this package
Seems that just "requires" of httpd (and samba-common for "wbpriv" group) is
enough. Both rpm and yum first install all the "Requires", and then
mod_auth_ntlm_winbind. Just checked it out now one more time.

> SVN ID of the upstream repository is 754
I use the SVN ID and the date of the latest change of this module, this way
seems to be more clean.

New SPEC:
http://dmitry.butskoy.name/mod_auth_ntlm_winbind/mod_auth_ntlm_winbind.spec
New SRPM:
http://dmitry.butskoy.name/mod_auth_ntlm_winbind/mod_auth_ntlm_winbind-0.0.0-0.2.20070129svn713.src.rpm




-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.