[Bug 244374] Review Request: xulrunner - XUL Runner

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: xulrunner - XUL Runner


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=244374





------- Additional Comments From caillon at redhat.com  2007-06-21 09:47 EST -------
* Make sure this passes rpmlint (i haven't actually tested that here).
* You're lucky with the patches, most of them just got committed upstream as
well and managed to make it into the tarball.  However, please copy
firefox-0.7.3-psfonts.patch from rawhide which marco said you guys need.  It
applies cleanly.
* I will let you slide with static linking for now as I'm guessing you have
packages dependent on that right now, but we probably want to fix their usage to
use the frozen APIs and get rid of that.  Do file a bug and cc me there to do that.
* Provides:   gecko-libs = %{version} gecko-libs <--- extra gecko-libs
* Your mozconfig also should define libdir in addition to prefix.  Since you are
exporting LIBDIR and PREFIX in the specfile (you copied from rawhide which is
good) you can simply copy the "ac_add_options --prefix="$PREFIX"  and
ac_add_options --libdir="$LIBDIR"
* Please move --with-system-nspr to be next to --with-system-nss for ease of
reference.  Those are tied very closely together.


-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.