[Bug 172869] Review Request: nss-mdns - glibc plugin for .local name resolution

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: nss-mdns - glibc plugin for .local name resolution


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=172869


tibbs at math.uh.edu changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|fedora-review?              |fedora-review+




------- Additional Comments From tibbs at math.uh.edu  2007-06-22 15:14 EST -------
(In reply to comment #39) 
[dist tag]
> Nope. I do not understand the issues. I just left in there what Bastien
> originally put in there. (Blame the frenchies!) Please enlighten me about the
> implications!

Sure.  First, see http://fedoraproject.org/wiki/Packaging/DistTag for an
overview.  The basic problem is that without the dist tag you have to keep
separate specs for each supported release, since you cannot have the same
version-release string on two different branches.  Usually new packagers not
using the dist tag import and build for rawhide, then try to import and build
for a release branch and get a nice useless error about trying to apply the same
tag to multiple branches when they go to build.

> I fixed that now and added fine-grained deps for post, preun, postun. For
> perl, ldconfig and /bin/sh. (does depending on /bin/sh make any real sense or 
> is it superfluous because it is such a basic tool anyway?)

Actually rpmbuild will automatically give you the proper dependency for the
shell needed to run a scriptlet.  So unless you use -p you get an automatic
depdency on /bin/sh, and if you have %postun -p /sbin/ldconfig then you get the
necessary Requires(postun): /sbin/ldconfig automatically.  So basically the two
dependencies on /bin/sh you have, along with the Requires(postun):
/sbin/ldconfig, are not really needed but aren't really harmful either.

> Unless /etc/nsswitch.conf is patched nss-mdns is entirely useless. You cannot
> run it manually, it just sits there and takes up some disk space.

Yes, I know, but you need it at package install/removal time to run the
scriptlets, not at any other time.  The difference is essentially academic in
any case.  The way you have things listed currently is OK.

> I also added a depends on avahi, given that Avahi is required to be installed
> to make nss-mdns any useful.

OK.

> I don't understand this entirely, but I think I fixed this with the 
> fine-grained dependencies, haven't I?

I always list out the full set of dependencies a package has, noting any bad
ones and mentioning any deficiencies I notice.

> BTW, how does one generate that review report you posted? That's not rpmlint
> output, is it?

Only three lines of that are rpmlint output; the rest is my usual review
template which I paste in and edit accordingly for each package I review.

At this point I think things are OK; you have some unnecessary dependencies as
mentioned above, but they're merely redundant and don't hurt anything.  You can
remove them when you check in if you like.

APPROVED

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.