[Bug 226167] Merge Review: mutt

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Merge Review: mutt


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=226167





------- Additional Comments From pertusus at free.fr  2007-06-25 16:48 EST -------
(In reply to comment #3)
> Thanks for looking at this.
> 
> (In reply to comment #1)
> > * maybe you could use gpgme?
> 
> What would be the advantage of including support for gpgme? It brings additional
> runtime dependencies, so it has to be really useful :).

I don't know at all but there is one muttrc option that
can only be set with gpgme:
crypt_use_pka


> > * I think that htmlview would be a better Requires than webclient,
> >   that way mutt may be installed without webclient and at the same
> >   time there is more chance that an html viewer will be selected
> >   if one is installed
> 
> Hm, htmlview depends on redhat-menus. I'd prefer to remove the webclient
> dependency and not depend on any external application beside sendmail and
> urlview (and perl from smime_keys). If user hasn't installed a browser, I think
> it's ok that s/he won't be able to start a browser from mutt.

Right.

> And maybe even the sendmail dependency can be removed since mutt has an smtp
> client compiled in.

That would allow to remove the Provides of msmtp, ssmtp and
esmtp, that would be nice.

> Ok, good point, urlview should be packaged separately.

Right.
  
> > * Maybe /etc/Muttrc may be made %config and not %config(noreplace)
> >   since there is Muttrc.local?
> 
> I'm not sure it's a good idea, I'd prefer to keep it as noreplace. Users can
> have /etc/Muttrc configured and ignore /etc/Muttrc.local.

This would allow to have a 'vendor/packager' defaults file that 
is under the control of the packager and allow to change things
when needed to.


> I'll fix the path. If xterm isn't installed, the application will be started in
> current terminal, so no need for the dependency.

Right.


> I'd prefer to not depend on anything, but I'm open to suggestions :).

If mutt depends on urlview, right it is better not to depend
on anything. But then urlview is sort of non-functional, though
this is not necessarily wrong since it allows to avoid dependencies
which is right for a program that allows for a choice.

If mutt doesn't depends on urlview, then I'd say it depends on you.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.