[Bug 245878] Review Request: stardict-dic-en - English(en) dictionaries for StarDict

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: stardict-dic-en - English(en) dictionaries for StarDict


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=245878





------- Additional Comments From rc040203 at freenet.de  2007-06-27 04:15 EST -------
<In reply to comment #2)
> How about add another dict next time?
Add another -a <N>

> So I think it is better to use the same
> scheme as other dic spec files.
OK, more bluntly: Your construct is a broken hack.

If you prefer one line per packages, then at least do it the rpm way:
%setup -c -T -n %{name}-%{version}
%setup -q -n %{name}-%{version} -D -T -a 0
%setup -q -n %{name}-%{version} -D -T -a 1

Compare what happens using this construct:

+ rm -rf stardict-dic-ja-2.4.2
+ /bin/mkdir -p stardict-dic-ja-2.4.2
+ cd stardict-dic-ja-2.4.2
++ /usr/bin/id -u
+ '[' 1005 = 0 ']'
++ /usr/bin/id -u
+ '[' 1005 = 0 ']'
+ /bin/chmod -Rf a+rX,u+w,g-w,o-w .
+ cd /home/user/src/rpms/BUILD
+ cd stardict-dic-ja-2.4.2
+ /usr/bin/bzip2 -dc /home/user/src/rpms/SOURCES/stardict-edict-2.4.2.tar.bz2

Against what happens with your contruct:
+ '[' '!' -d stardict-dic-ja-2.4.2 ']'
+ cd /home/user/src/rpms/BUILD
+ cd stardict-dic-ja-2.4.2
+ /usr/bin/bzip2 -dc /home/user/src/rpms/SOURCES/stardict-edict-2.4.2.tar.bz2
+ tar -xf -

=> MUSTFIX


-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.