[Bug 225746] Merge Review: fedora-release
bugzilla at redhat.com
bugzilla at redhat.com
Thu Jun 28 14:32:30 UTC 2007
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.
Summary: Merge Review: fedora-release
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=225746
------- Additional Comments From jkeating at redhat.com 2007-06-28 10:32 EST -------
(In reply to comment #9)
> License: FAIL (GFDL vs. GPL)
Will fix.
> %files
> %defattr(-,root,root,-)
> %attr(0644,root,root) /etc/fedora-release
> /etc/redhat-release
> %dir /etc/yum.repos.d
> %config(noreplace) /etc/yum.repos.d/*
> %doc GPL
> %config(noreplace) %attr(0644,root,root) /etc/issue
> %config(noreplace) %attr(0644,root,root) /etc/issue.net
> %config(noreplace) %attr(0644,root,root) /etc/rpm/macros.dist
> %dir /etc/pki/rpm-gpg
> /etc/pki/rpm-gpg/*
>
> Makes me want to scream!
> 1. Please oh please don't put a %doc in the middle of a list of /etc files
Heh, will move up. Love inherited packages.
> 2. %attr's seem redundant, 0644 can be implyed with install or even cp
Yeah, probably best to do it at install time.
> 3. I *think* %dir /etc/pki/rpm-gpg is redundant
Maybe. We want to own that dir and not just the files within it. Will experiment.
> 4. I believe %{_sysconfdir} is perfered over /etc/file
Preferred but not necessary. Will consider.
> Spec file claims GFDL where the tarball provides GPL
Yeah, need to fix that.
> rpmlint:
> W: fedora-release non-conffile-in-etc /etc/pki/rpm-gpg/RPM-GPG-KEY
> W: fedora-release non-conffile-in-etc /etc/pki/rpm-gpg/RPM-GPG-KEY-beta
> W: fedora-release non-conffile-in-etc /etc/pki/rpm-gpg/RPM-GPG-KEY-fedora-test
> W: fedora-release non-conffile-in-etc /etc/pki/rpm-gpg/RPM-GPG-KEY-fedora-rawhide
> W: fedora-release non-conffile-in-etc /etc/pki/rpm-gpg/RPM-GPG-KEY-fedora
That's correct, these aren't config files, they're data... that happens to live
in a config directory.
> W: fedora-release non-conffile-in-etc /etc/fedora-release
We want to overwrite this file on upgrades. Suppose it could be config but
without noreplace.
> W: fedora-release non-conffile-in-etc /etc/pki/rpm-gpg/RPM-GPG-KEY-rawhide
See above about other gpg keys.
> W: fedora-release unversioned-explicit-obsoletes redhat-release
> W: fedora-release unversioned-explicit-provides redhat-release
>
> (last two are okay)
>
> I'll set to reviewed when changes hit cvs
Working....
--
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.
More information about the Fedora-package-review
mailing list