[Bug 243951] Review Request: pbm2l7k - Converts PBM stream to Lexmark 7000, 7200 and 5700 printer language

bugzilla at redhat.com bugzilla at redhat.com
Thu Jun 28 22:11:13 UTC 2007


Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: pbm2l7k - Converts PBM stream to Lexmark 7000, 7200 and 5700 printer language
Alias: pbm2l7k-review

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=243951


mmahut at redhat.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|fedora-review?, fedora-cvs- |fedora-review+, fedora-cvs?




------- Additional Comments From mmahut at redhat.com  2007-06-28 18:11 EST -------
+ source files match upstream:
         0f255d21fa2608094a2e40f5130ceee1 
/usr/src/redhat/SOURCES/lexmark7000linux-990321.tar.gz
+ package meets naming and versioning guidelines.
+ specfile is properly named, is cleanly written and uses macros consistently.
+ dist tag is present.
+ build root is correct.
      %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n)
+ license field matches the actual license.
+ license is open source-compatible.  
+ latest version is being packaged.
+ compiler flags are appropriate.
+ %clean is present.
+ package installs properly
+ debuginfo package looks complete.
+ rpmlint is silent.
+ final provides and requires are sane:
  [root at storm pbm2l7k]# rpm -qp --provides
/usr/src/redhat/RPMS/i386/pbm2l7k-990321-1.fc8.i386.rpm
  pbm2l7k = 990321-1.fc8
  [root at storm pbm2l7k]# rpm -qp --requires
/usr/src/redhat/RPMS/i386/pbm2l7k-990321-1.fc8.i386.rpm
  libc.so.6  
  libc.so.6(GLIBC_2.0)  
  libc.so.6(GLIBC_2.1)  
  libc.so.6(GLIBC_2.3.4)  
  libc.so.6(GLIBC_2.4)  
  rpmlib(CompressedFileNames) <= 3.0.4-1
  rpmlib(PayloadFilesHavePrefix) <= 4.0-1
  rtld(GNU_HASH)  
  [root at storm pbm2l7k]# 
+ doesn't own any directories it shouldn't.
+ no duplicates in %files.
+ file permissions are appropriate.


APPROVED

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.




More information about the Fedora-package-review mailing list