[Bug 230512] Review Request: viewvc- Browser interface for CVS and SVN version control repositories

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: viewvc-  Browser interface for CVS and SVN version control repositories


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=230512





------- Additional Comments From bjohnson at symetrix.com  2007-03-01 14:48 EST -------
> # sitelib for noarch packages, sitearch for others (remove the unneeded one)
%{!?python_sitelib: %define python_sitelib %(%{__python} -c "from 
> distutils.sysconfig import get_python_lib; print get_python_lib()")}
%{!?python_sitearch: %define python_sitearch %(%{__python} -c "from 
> distutils.sysconfig import get_python_lib; print get_python_lib(1)")}

You can remove the sitearch line if your package is a noarch.

> Requires:       httpd, mod_python, subversion >= 1.2, rcs, diffutils

You require both cvs (rcs) and subversion file even though someone could use one
or the other.  Is there a better way to do this?

You are also setting up the include file for cvsgraph, but not requiring cvsgraph.

GNU enscript is already available in Extras.  If you require and configure for
enscript you can have sytax highlighting.

The INSTALL files says that you need subversion python bindings - it appears
that those are in the main subversion package?

> %doc CHANGES README INSTALL TODO
Normally we don't include INSTALL files, except in this case it has additional
instruction on how to setup the mysql commit database (if someone wants to do
that at a later time), so it is useful.

The COMMITTERS file lists the contributors to the project, so it should be
included in %doc.

Are ./www and ./viewvc.org useful docs?

In viewvc.conf:
>     AddHandler python-program .py
>     PythonHandler handler

will require mod_python (which you do).  This is only one way of running viewvc.
 Is there any particular reason that you've chosen this method?  Is this the
best way?

In viewvc.conf:
> #    PythonDebug On
remove :)


> Requires:       httpd, mod_python, subversion >= 1.2, rcs, diffutils

If you require mod_python, you don't need httpd because it will be found by
dependency of mod_python on httpd.

I'll have to dig into the substitutions you're doing, but that will take me a
little longer.

Here are the rpmlint complaints for you package:
E: viewvc script-without-shebang
/usr/lib/python2.4/site-packages/viewvc/bin/mod_python/query.py
E: viewvc script-without-shebang
/usr/lib/python2.4/site-packages/viewvc/bin/mod_python/handler.py
E: viewvc non-executable-script
/usr/lib/python2.4/site-packages/viewvc/lib/vclib/ccvs/blame.py 0644
E: viewvc non-executable-script
/usr/lib/python2.4/site-packages/viewvc/lib/py2html.py 0644
E: viewvc non-executable-script
/usr/lib/python2.4/site-packages/viewvc/lib/compat_difflib.py 0644
E: viewvc non-executable-script
/usr/lib/python2.4/site-packages/viewvc/lib/compat_ndiff.py 0644
E: viewvc non-executable-script
/usr/lib/python2.4/site-packages/viewvc/lib/query.py 0644
E: viewvc non-executable-script
/usr/lib/python2.4/site-packages/viewvc/lib/ezt.py 0644
E: viewvc htaccess-file
/usr/lib/python2.4/site-packages/viewvc/bin/mod_python/.htaccess
E: viewvc script-without-shebang
/usr/lib/python2.4/site-packages/viewvc/bin/mod_python/.htaccess
E: viewvc script-without-shebang
/usr/lib/python2.4/site-packages/viewvc/bin/mod_python/viewvc.py
E: viewvc non-executable-script
/usr/lib/python2.4/site-packages/viewvc/lib/blame.py 0644
W: viewvc setup-not-quiet
W: viewvc mixed-use-of-spaces-and-tabs (spaces: line 5, tab: line 41)


-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.