[Bug 230812] tcpxtract - tool for extracting files from network traffic based on file signatures

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: tcpxtract -  tool for extracting files from network traffic based on file signatures


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=230812


mtasaka at ioa.s.u-tokyo.ac.jp changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |mtasaka at ioa.s.u-tokyo.ac.jp




------- Additional Comments From mtasaka at ioa.s.u-tokyo.ac.jp  2007-03-02 21:19 EST -------
A comment (well, I am currently reviewing more than 10 bugs,
so I hope someone else will review this report).

* hardcoded path 
  - The path of DEFAULT_CONFIG_FILE is hardcoded, which should be
    avoided generally.
  * If it cannot be avoided to use hardcoded path, so don't use
    %{_sysconfdir} and use hardcoded path in spec file to make
    them consistent
  * Generally, the method like
----------------------------------------------------------
%{__sed} -i.path -e '/DEFAULT_CONFIG_FILE/s|/usr/local/etc|%{_sysconfdir}||'
tcpxtract.c
----------------------------------------------------------
     is used to pass macro correctly.

* Timestamps
  - Keep timestamps on man file and conf file. Perhaps
----------------------------------------------------------
make install DESTDIR=$RPM_BUILD_ROOT install="%{_install} -c -p"
----------------------------------------------------------
    will do the trick.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.