[Bug 229600] Review Request: specto - An desktop application that will watch configurable events
bugzilla at redhat.com
bugzilla at redhat.com
Tue Mar 6 16:52:50 UTC 2007
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.
Summary: Review Request: specto - An desktop application that will watch configurable events
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=229600
------- Additional Comments From mtasaka at ioa.s.u-tokyo.ac.jp 2007-03-06 11:52 EST -------
Well, for -2:
* Dictory ownership
- Still not okay.
-----------------------------------------
%{_datadir}/icons/hicolor/*
-----------------------------------------
/usr/share/icons/hicolor/scalable
/usr/share/icons/hicolor/scalable/apps
are owned by hicolor-icon-theme.
* Requirement
- Well, gnome-python2-gconf requires gnome-python2 and there is
no circular dependencies between these two.
So "Requires: gnome-python2" is redundant, sorry.
* Needed "documentation" file
- Well, currently, when I push "Help -> About" button:
--------------------------------------------------------
[tasaka1 at localhost specto-0.2.0-2.fc7]$ LANG=C specto
GTK Accessibility Module initialized
Traceback (most recent call last):
File "/usr/lib/python2.5/site-packages/spectlib/notifier.py", line 859, in
show_about
self.specto.show_about()
File "/usr/lib/python2.5/site-packages/spectlib/main.py", line 539, in show_about
self.about = About(self)
File "/usr/lib/python2.5/site-packages/spectlib/about.py", line 38, in __init__
version_file=open(version_file_path, 'r')
IOError: [Errno 2] No such file or directory: '/usr/share/doc/specto/VERSION'
--------------------------------------------------------
This program surely expects that "VERSION" should be installed
under /usr/share/doc/specto.
However, this means that
* The file "VERSION" should be installed
* This file cannot be regardes as a "documentation" because
this file is required by this program.
This also applies to "COPYING" file.
So generally should should
* install the two files _also_ under somewhere (here, say %{_datadir}/%{name})
* modify the related python scripts
Well, I am not a expert of python, however if you install _also_
under /usr/share/specto,
--------------------------------------------------------
--- about.py.orig 2007-03-06 14:21:37.000000000 +0900
+++ about.py 2007-03-07 01:45:01.000000000 +0900
@@ -34,11 +34,11 @@
def __init__(self, specto):
self.specto = specto
- version_file_path = (spectlib.util.get_path(category="doc") + 'VERSION')
+ version_file_path = (spectlib.util.get_path() + 'VERSION')
version_file=open(version_file_path, 'r')
version = str(version_file.readline()[:-1]) # "[:-1]" means we omit the
last character, which is "\n".
version_file.close
- license_file_path = (spectlib.util.get_path(category="doc") + 'COPYING')
+ license_file_path = (spectlib.util.get_path() + 'COPYING')
license_file = open(license_file_path, "r")
license = license_file.read()
license_file.close()
--------------------------------------------------------
seems to work.
--
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.
More information about the Fedora-package-review
mailing list