[Bug 229342] Review Request: nfs4-acl-tools - ACL utilities for NFSv4

bugzilla at redhat.com bugzilla at redhat.com
Tue Mar 6 20:40:32 UTC 2007


Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: nfs4-acl-tools - ACL utilities for NFSv4


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=229342


tcallawa at redhat.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |tcallawa at redhat.com




------- Additional Comments From tcallawa at redhat.com  2007-03-06 15:40 EST -------
Steve, you owe me a Stuffed Pizza for this. ;)

I took a look at fixing up the source for this package a bit, and I found the
following items:

- The source has no concept of "DESTDIR", which is pretty easy to fix.
- It was doing some brain-dead checking for the existence of nfs_editfacl. I
fixed it up a bit, and now it makes a correct symlink.
- The source was completely obliterating any LDFLAGS passed to it, configure saw
them, but the include/buildmacros was just overwriting them blindly. I fixed
that too.

With that done, I was able to simplify the spec significantly, normalize it, and
lose the need for the autotools BuildRequires.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.




More information about the Fedora-package-review mailing list