[Bug 231005] gnome-vfs2-obexftp: ObexFTP filesystem support for GNOME

bugzilla at redhat.com bugzilla at redhat.com
Tue Mar 6 21:13:17 UTC 2007


Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: gnome-vfs2-obexftp: ObexFTP filesystem support for GNOME


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=231005





------- Additional Comments From ville.skytta at iki.fi  2007-03-06 16:13 EST -------
Initial comments from just skimming the srpm, possibly a full review later
unless someone beats me to it:

- --with-compile-warnings=no to configure seems to be a no-op

- --disable-dependency-tracking to configure would result in cleaner build
output and possibly slightly faster build.

- License file missing from %doc - is the package GPL or LGPL?  Both files are
included in the upstream tarball, but it seems to me that this is LGPL and thus
COPYING.LIB should only be included.  Upstream could be interested in clarifying
this in future releases.

- Cosmetics: both %buildroot and $RPM_BUILD_ROOT used, should stick with one

- Doesn't parallel build (make %{?_smp_mflags}) work?

- %makeinstall used - doesn't 'make install DESTDIR=$RPM_BUILD_ROOT' work?

- If hcid needs to be started with -x using the bluetooth init script, a bug
should be opened against bluez-utils asking to make it possible to set hcid
options in a /etc/sysconfig/* snippet, and have that bug block this one.  Or did
you mean starting hcid some other way?

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.




More information about the Fedora-package-review mailing list