[Bug 229342] Review Request: nfs4-acl-tools - ACL utilities for NFSv4

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: nfs4-acl-tools - ACL utilities for NFSv4


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=229342


tibbs at math.uh.edu changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEEDINFO                    |ASSIGNED
               Flag|fedora-review?,             |fedora-review+
                   |needinfo?(tibbs at math.uh.edu)|




------- Additional Comments From tibbs at math.uh.edu  2007-03-09 10:22 EST -------
OK, let's check it out.

Yes, it builds fine now; the only thing rpmlint has to say now is the
  previously addressed "non-standard-group" bit.
The spec is far cleaner, and things look good there.
The license tag is fine and the license is in the package.

The only thing that gives me any pause is the fact that the package is
building a static library and then statically linking the binaries against
it.  I don't think this actually violates any guidelines, however, since the
static library isn't being shipped.  I guess converting to a shared library
is something that upstream could consider for a future release, especially if
other packages could benefit from being able to use it.

In any case, all of the blockers have been dealt with.

APPROVED


-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.