[Bug 208034] Review Request: HippoDraw - Interactive and Python scriptable data analysis application
bugzilla at redhat.com
bugzilla at redhat.com
Sun Mar 11 15:29:38 UTC 2007
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.
Summary: Review Request: HippoDraw - Interactive and Python scriptable data analysis application
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=208034
------- Additional Comments From mtasaka at ioa.s.u-tokyo.ac.jp 2007-03-11 11:29 EST -------
Created an attachment (id=149793)
--> (https://bugzilla.redhat.com/bugzilla/attachment.cgi?id=149793&action=view)
mock build log of 1.19.5-1 with graphviz-gd added to BR
Well, for 1.19.5-1:
* Requires (for -devel and -python package)
---------------------------------------------------
(In reply to comment #27)
>> * Requires
>> - not fixed at all. Please check my previous comment 22.
>> NOTE: Here what I mean is that you have to add something
>> to "Requires", not "BuildRequires".
>
> I think I fixed it correctly knowing what is needed at runtime for the
>application. Which item do you think is wrong?
---------------------------------------------------
- For main package (HippoDraw), it is okay.
For -devel and -python package, it is not yet okay.
Well, as I wrote on comment 22,
* Example
/usr/include/HippoDraw/qt/QtFileDialog.h contains the line:
---------------------------------------------------
16
17 #include <qglobal.h> // for version
18 #if QT_VERSION < 0x040000
19 #include <qfiledialog.h>
20 #else
21 #include <q3filedialog.h>
22 #endif
---------------------------------------------------
This means that HippoDraw-devel should have
"Requires: qt-devel". However, currently HippoDraw-devel
can be installed without qt-devel.
This is wrong because
---------------------------------------------------
[tasaka1 at localhost HippoDraw]$ cat TMP.cc
#include <HippoDraw/qt/QtFileDialog.h>
int main(){
return 0;
}
[tasaka1 at localhost HippoDraw]$ LANG=C g++ -o TMP TMP.cc
-I/usr/lib/qt-3.3/include -L/usr/lib/qt-3.3/lib -lqt-mt
In file included from TMP.cc:1:
/usr/include/HippoDraw/qt/QtFileDialog.h:17:36: error: qglobal.h: No such file
or directory
/usr/include/HippoDraw/qt/QtFileDialog.h:19:25: error: qfiledialog.h: No such
file or directory
/usr/include/HippoDraw/qt/QtFileDialog.h:69: error: 'QWidget' has not been
declared
/usr/include/HippoDraw/qt/QtFileDialog.h:125: error: 'QWidget' has not been
declared
/usr/include/HippoDraw/qt/QtFileDialog.h:137: error: 'QWidget' has not been
declared
/usr/include/HippoDraw/qt/QtFileDialog.h:151: error: 'QWidget' has not been
declared
/usr/include/HippoDraw/qt/QtFileDialog.h:157: error: 'QWidget' has not been
declared
---------------------------------------------------
This succeeds with qt-devel installed.
* For -python, what is the following?
---------------------------------------------------
%description python
Provides Python module to use %{name} from Python scripts.
Requires: python-numarray
---------------------------------------------------
This is a description and this does not
"Requires: python-numarray" to -python package.
You must write "Requires:" section below "Group" description.
* Same for -devel-docs packge.
Requires: description should not be in %description section.
* Macro
---------------------------------------------------
%{configure} --without-wcslib-lib --without-minuit2-lib --without-root-lib\
--disable-rpath --with-boost-root=/usr
---------------------------------------------------
Please use %{_prefix} for /usr.
* Build order
> > * Build order
> > - By the way, can it be moved to %build stage to
> > make doxygen called to build documentation?
>
> That could be done if you think it is important enough.
>
- If possible, please do. Normally rebuilding should be done in
%build stage and %install stage is only for install.
* For graphviz
> >* Build log
> > - Can the following(s) be ignored?
> ----------------------------------------------------
> > Generating docs for filRenderer type: "gif" not recognized.
> > Use one of: canon cmap cmapx dia dot fig gtk hpgl imap ismap mif mp
> > pcl pdf pic plain plain-ext png ps ps2 svg svgz vtx xdot xlib
> > Problems running dot. Check your installation!
>
> I don't see that message on FC6 with
>
> rpm -qf /usr/bin/dot
> graphviz-2.8-5.fc6
>
> If dot is not generating .gif files, then the documentation in package
> HippoDraw-devel-docs are not going to look right.
- Confirmed that this doesn't happen on FC-6.
Turns out that this is due to graphviz-gd sprit out on FC-devel
NOTE: currently on FC-devel:
-------------------------------------------------------
bash-3.2# rpm -q graphviz
graphviz-2.12-6.fc7
-------------------------------------------------------
For me it is okay with the following added.
-------------------------------------------------------
--- HippoDraw.spec~ 2007-03-11 05:00:06.000000000 +0900
+++ HippoDraw.spec 2007-03-12 00:21:55.000000000 +0900
@@ -13,6 +13,9 @@
BuildRequires: cfitsio-devel qt-devel desktop-file-utils doxygen graphviz
+%if 0%{?fedora} >= 7
+BuildRequires: graphviz-gd
+%endif
BuildRequires: tetex-latex tetex-dvips netpbm-progs ghostscript
Requires: cfitsio tetex-latex tetex-dvips netpbm-progs ghostscript
-------------------------------------------------------
* Changelog
> I'm using rpm mode in emacs to generate the entries. It picks up my userid
> on my laptop that I'm using for development. You'll note the machine name
> changes depending on whether I'm at work or at home due to different DHCP
> server. Should I manually fix all of them?
- Normally the email of Changelog and bugzilla entry should be
the same.
Please fix the email address for new changelog entry (it is okay
for the changelog already written).
--
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.
More information about the Fedora-package-review
mailing list