[Bug 225791] Merge Review: gettext

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Merge Review: gettext


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=225791





------- Additional Comments From mtasaka at ioa.s.u-tokyo.ac.jp  2007-03-13 09:12 EST -------
Created an attachment (id=149922)
 --> (https://bugzilla.redhat.com/bugzilla/attachment.cgi?id=149922&action=view)
normal rpmbuild log of 0.16.1-6 on FC-devel i386

* About rpmbuild as non-root users
  - Well, as the attached log shows, currently
    normal rpmbuild fails when it is done by non-root users,
    more precisely, by users who do not have /sbin in
    their path.
    After explicitly adding /sbin to PATH, rpmbuild
    succeeds.

    Perhaps the related points are in 
    ./gettext-runtime/libasprintf/Makefile.in (other files
    may be also related)
-------------------------------------------------
   868		@$(POST_INSTALL)
   869		@if (install-info --version && \
   870		     install-info --version 2>&1 | sed 1q | grep -i -v debian)
>/dev/null 2>&1; then \
   871		  list='$(INFO_DEPS)'; \
   872		  for file in $$list; do \
   873		    relfile=`echo "$$file" | sed 's|^.*/||'`; \
   874		    echo " install-info --info-dir='$(DESTDIR)$(infodir)'
'$(DESTDIR)$(infodir)/$$relfile'";\
   875		    install-info --info-dir="$(DESTDIR)$(infodir)"
"$(DESTDIR)$(infodir)/$$relfile" || :;\
   876		  done; \
   877		else : ; fi
-------------------------------------------------
    Well, when "install-info" is in their path, install-info
    is executed and %{buildroot}/usr/share/info/dir is created, then
-------------------------------------------------
    87	
    88	rm ${RPM_BUILD_ROOT}%{_infodir}/dir
    89	
-------------------------------------------------
    in spec file succeeds. However when install-info
    is not in their path, dir file is not created and
    this fails.

    NOTE:
    - Currently mockbuild does:
--------------------------------------------------------
DEBUG: Executing /usr/sbin/mock-helper chroot
/var/lib/mock/fedora-development-i386-core/root /sbin/runuser - root -c "cd
/;/sbin/runuser -c 'rpmbuild --rebuild	--target i386 --nodeps
/builddir/build/SRPMS/gettext-0.16.1-6.fc7.src.rpm' mockbuild"
--------------------------------------------------------
       So when mockbuild is done, the path is set as same
       as which root sets.
    So:
    * The most simple way is just to "rm -f"

* rpmlint
  - rpmlint for 0.16.1-6 is
----------------------------------------------
W: gettext unstripped-binary-or-object /usr/lib/preloadable_libintl.so
E: gettext no-ldconfig-symlink /usr/lib/preloadable_libintl.so
W: gettext-devel unused-direct-shlib-dependency /usr/lib/libasprintf.so.0.0.0
/lib/libm.so.6
E: gettext-devel zero-length
/usr/share/doc/gettext-devel-0.16.1/javadoc2/package-list
-----------------------------------------------
   - For the first one (unstripped-binary-or-object), rpmbuild
     doesn't strip libraries when libraries does not have
     executable permissions when %install stage is done
     (adding %attr does not make sense for stripping)

     To strip this, the permission of preloadable_libintl.so
     has to be changed explicitly to 0755.
   - I don't know well about preloadable_libintl.so, however
     can the second rpmlint error (about ldconfig symlink)
     ignored?
   - What is the file "package-list"?

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.