[Bug 225235] Merge Review: a2ps

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Merge Review: a2ps


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=225235





------- Additional Comments From pertusus at free.fr  2007-03-14 05:22 EST -------
(In reply to comment #33)
> ok, So where do we stand on this package now?
> 
> Looking at the latest version I now see the following from rpmlint: 
> 
> W: a2ps file-not-utf8 /usr/share/info/a2ps.info.gz
> 
> Run iconv on it? 

I have checked, the problematic string is in doc/encoding.texi, it is:

  KOI-8 (+�) is a subset of ISO-IR-111 that can be used in Serbia, Belarus

maybe use iconv -f KOI-8?

> W: a2ps non-conffile-in-etc /etc/a2ps.cfg
> 
> Shouldn't that be %config? Patrice, you suggested it shouldn't be config? why? 
> It's in /etc and it's something that people might modify isn't it?

Normally it shouldn't be modified by the users
At the end there is this comment:
# To avoid that the next installation of a2ps destroys your
# definitions, local customization would be better done in
# a2ps-site.cfg.

Well, maybe it would better be %config. But in  my opinion 
%config(noreplace) isn't right.

> E: a2ps postin-without-ldconfig /usr/lib/liba2ps.so.1.0.0
> E: a2ps library-without-ldconfig-postun /usr/lib/liba2ps.so.1.0.0
> 
> Missing postin/postun ldconfig? 

Certainly, I forgot to readd them when I readed the libraries.

> W: a2ps dangerous-command-in-%post mv
> W: a2ps strange-permission a2ps-generate-tarball.sh 0755
> 
> These can be ignored I think. 
> 
> I don't see anything else in my orig items thats not been addressed. 
> Patrice? Anything you see holding up approval of this package?

No, except missing ldconfig.



-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.