[Bug 227085] Review Request: maven-wagon-1.0-0.a5.3jpp - Maven Wagon

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: maven-wagon-1.0-0.a5.3jpp - Maven Wagon


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=227085


mwringe at redhat.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|mwringe at redhat.com          |tbento at redhat.com




------- Additional Comments From mwringe at redhat.com  2007-03-14 13:44 EST -------
(In reply to comment #3)
> ...
> X verify source and patches (md5sum matches upstream, know what the patches do)
>   - if upstream doesn't release source drops, put *clear* instructions on
>     how to generate the the source drop; ie. 
>    # svn export blah/tag blah
>    # tar cjf blah-version-src.tar.bz2 blah
> 
>  The md5sum do not match.  When I do a diff, I get the following:
>   diff -r
>
wagon-1.0-alpha-5/wagon-provider-api/src/main/java/org/apache/maven/wagon/util/IoUtils.java
>
../upstream/wagon-1.0-alpha-5/wagon-provider-api/src/main/java/org/apache/maven/wagon/util/IoUtils.java
> 80c80
> <  * @version CVS $Revision: 290775 $ $Date: 2005-09-21 20:25:08 +0200 (Wed, 21
> Sep 2005) $
> ---
> >  * @version CVS $Revision: 290775 $ $Date: 2005-09-21 14:25:08 -0400 (Wed, 21
> Sep 2005) $
> 
>  I think this is okay.
Hmm, interesting, I just did another source export so this should not be an
issue anymore
    
> X skim the summary and description for typos, etc.
>  Summary should be "Tools to manage artifacts and deployment".
> 
> * correct buildroot
>  - should be:
>    %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n)
>   OK
> 
> * if %{?dist} is used, it should be in that form (note the ? and %
> locations)
>  OK
> 
> X license text included in package and marked with %doc
>  There is no license text included in package, so this is OK.
> 
> * keep old changelog entries; use judgement when removing (too old?
> useless?)
>  OK
> 
> * packages meets FHS (http://www.pathname.com/fhs/)
>  OK
> 
> X * rpmlint on <this package>.srpm gives no output
>  - justify warnings if you think they shouldn't be there
>  W: maven-jxr non-standard-group Development/Java
>  W: maven-jxr non-standard-group Development/Java
>  Both of these warnings can be ignored.
> 
> 
> ...  
> X make sure lines are <= 80 characters
>  OK (only code lines are > 80)
>  There are some lines with more than 80 characters, but they are code lines and
>    rpmlint did not complain about them, so this is OK.
The 80 character length restriction only applies to the description.

> 
> ...
> Other Notes:
> - Removed "%define section free".
removed

> - Should gcj support be added?
since this package will be updated at a later date to support a maven2 build, I
would suggest adding the gcj support aot bits at that time. 

New Files:
https://mwringe.108.redhat.com/files/documents/175/301/maven-wagon.spec
https://mwringe.108.redhat.com/files/documents/175/302/maven-wagon-1.0-0.1.a5.3jpp.1.src.rpm

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.