[Bug 231746] Review Request: ettercap - Network traffic sniffer/analyser

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: ettercap - Network traffic sniffer/analyser


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=231746





------- Additional Comments From wolfy at nobugconsulting.ro  2007-03-14 14:53 EST -------
OK, here we go.
Between square brackets I have included references to items listed under
"Problems" below. Please observe the "MUSTFIX"es included over there.

GOOD:
- rpmlint output:
[wolfy at wolfy64 ettercap]$ rpmlint ~/ettercap-0.7.3-6.src.rpm
W: ettercap unversioned-explicit-provides ettercap
->I assume it's triggered by the line in "%package gtk" and can be safely ignored
[wolfy at wolfy64 ettercap]$ rpmlint ettercap-common-0.7.3-6.fc7.x86_64.rpm
W: ettercap-common dangling-relative-symlink /usr/bin/ettercap-text ./ettercap
W: ettercap-common dangling-relative-symlink /usr/bin/ettercap-curses ./ettercap
-> can be ignored, the target will be there when either ettercap or ettercap-gtk
is installed
[wolfy at wolfy64 ettercap]$ rpmlint ettercap-0.7.3-6.fc7.x86_64.rpm
[wolfy at wolfy64 ettercap]$ rpmlint ettercap-gtk-0.7.3-6.fc7.x86_64.rpm
W: ettercap-gtk no-documentation
-> can be ignored, docs are in -common

- package meets naming guidelines
- package meets packaging guidelines
- license (GPL) OK, text is included in %doc, matches source 
- spec file legible, in am. english
- source matches upstream, sha1sum 
7a2c3f848ca4f39c07fddeb0d6308641265bc4ff  ettercap-NG-0.7.3.tar.gz [1]
- package compiles on devel (x86)
- no missing BR [2]
- no unnecessary BR
- no locales
- not relocatable
- owns all files/directories that it creates, does not take ownership of foreign
files/folders
- no duplicate files
- permissions ok
- %clean ok
- macro use consistent
- code, not content
- most docs are included in the -common package, except for the man page
specific to the ncurses interface [2]
- nothing in %doc affects runtime
- a .desktop file is conveniently installed for the gtk interface [3]
- no .la/static/pkconfig files
- scriptlets are sane


SHOULD:

OK: runs as advertised
OK: builds happily in mock for devel and fc6 (x86_64)
OK: require of subpackage is fully versioned


Problems

MUSTFIX: [1] - Timestamp of original file is not preserved in the src.rpm;
please use wget -N ( or similar tool ) to fix that;the timestamp of the man
pages is not preserved either
[2] - adding libtool-ltdl-devel as BR (instead of libtool) allows bulding of the
plugins. I have verified and there are no problems, they just need to be
included in a package. I suggest a 4th package (ettercap-plugins) for that (this
is a nice to have, technically is not a blocker, just a possible, easy to add
but missing feature)
MUSTFIX: [3] - the desktop file has an error: wrong path (includes an
unexpandable rpm macro) for the icon; just drop the full path, rpm will take
care at install time (the error is still present in the release 7 of the spec)
MUSTFIX: [4] - There is a whole folder with docs (/doc, huh), missing; I suggest
removing INSTALL, README.BINARIES, README.CVS and even README.PLATFORMS, they
provide no useful info for a final user who only wants to run the application.
MUSTFIX: the -common packages creates symlinks which are not valid unless the
text-only rpm is installed. This is not nice. I think that a bit of magic is
needed here. One fix could be to create the symlinks in %post in the text and
gtk rpms, and only if they do not exist already.
- you can dump "Provides ettercap" in the -gtk package. I have just tested after
a build without it and everything seems fine:
[root at wolfy64 x86_64]# yum provides ettercap
Loading "skip-broken" plugin
Loading "installonlyn" plugin
Setting up repositories
Reading repository metadata in from local files
updates   : ################################################## 1613/1613
core      : ################################################## 2931/2931
extras    : ################################################## 6071/6071
LOCALx86_6: ################################################## 5/5
ettercap-gtk.x86_64                      0.7.3-6.fc6            LOCALx86_64
Matched from:
ettercap
ettercap.x86_64                          0.7.3-6.fc6            LOCALx86_64
Matched from:
ettercap


-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.