[Bug 231746] Review Request: ettercap - Network traffic sniffer/analyser

bugzilla at redhat.com bugzilla at redhat.com
Wed Mar 14 20:19:39 UTC 2007


Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: ettercap - Network traffic sniffer/analyser


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=231746





------- Additional Comments From wolfy at nobugconsulting.ro  2007-03-14 16:19 EST -------
WRT comment#47
Minor: The spec from release 8 has an unneeded BR (libtool, pulled by
libtool-ltdl-devel, as specified in comment $45 /2 ). 
Mustfix: If you do not include in a package the additional files ( %configure
sees the additional available libs and build the plugins by default) which are
generated by enabling ltdl, build is terminated with an error (unpackaged
files). Pay attention to the .la files which are generated during the build of
plugins, they must be removed.

WRT comment #48: I will not hold approval because of this, but preserving
timestamps is heavily recommended. I have to recheck why is the date modified.
AFAIK rpm by itself does not do that, simply because it calls gzip which
preserves timestamps. But not today, I really had a rough day today.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.




More information about the Fedora-package-review mailing list