[Bug 231746] Review Request: ettercap - Network traffic sniffer/analyser

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: ettercap - Network traffic sniffer/analyser


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=231746





------- Additional Comments From wolfy at nobugconsulting.ro  2007-03-15 10:21 EST -------
You have forgotten to include the /doc folder in %doc (or at least explain why
it is not to be included; to me the files over there seem useful for people who
want to expand the existing capabilities of the program). While at the docs, I
think that including README is a good idea, as it talks about the license and
also gives some explanations on the internals of the program.

I've found the explanation of the modified timestamps for man pages: the
original tar.gz includes the man pages both as a final version and as automake
generated files; %configure overwrites the existing pages because it generates
them again:
Writing output files...

configure: creating ./config.status
config.status: creating Makefile
config.status: creating Makefile.mingw
config.status: creating man/Makefile
config.status: creating man/ettercap.8
config.status: creating man/ettercap_curses.8
config.status: creating man/ettercap_plugins.8
config.status: creating man/etterlog.8
config.status: creating man/etterfilter.8
config.status: creating man/etter.conf.5


The solution for solving the symlink/alternative issue is up to you, use
whatever looks cleaner. You can go straight ahead and use Till's suggestion
(don't forget to require alternatives in this case), or emulate alternatives
using %post ("if link exists, exit; otherwise create it) and %postun (if link
exists and points to self, remove). I guess alternatives is less error prone...

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.