[Bug 225863] Merge Review: gsl

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Merge Review: gsl


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=225863





------- Additional Comments From pertusus at free.fr  2007-03-15 19:03 EST -------
* URL seems to be
http://www.gnu.org/software/gsl/

and source should certainly come from gnu.

* missing dot at the end of %descriptions

* Why isn't the pkgconfig file distributed????

* the gsl-config script created on the fly certainly needs a comment.
And is strange anyway. 

It would be better, in my opinion either
  - to create a wrapper around pkg-config calls that recreates the 
    gsl-config output.
  - or leave gsl-config as is, if not using pkgconfig it is expected
    to have multilib stuff broken.

* if the code is still usefull, instead of
gslcsuffix=`echo "%{_libdir}" | sed s,/usr/,,`
I suggest using %_lib

* .la files are still there

Suggestions:
* remove .gz from install-info snippets

* use %defattr(-,root,root,-) instead of %defattr(-,root,root)

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.