[Bug 231707] Review Request: perl-CGI-Session - Persistent session data in CGI applications
bugzilla at redhat.com
bugzilla at redhat.com
Sat Mar 17 04:05:19 UTC 2007
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.
Summary: Review Request: perl-CGI-Session - Persistent session data in CGI applications
Alias: perl-CGI-Session
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=231707
------- Additional Comments From cweyl at alumni.drew.edu 2007-03-17 00:05 EST -------
Replace %fedora conditional with a buildrequires: perl(ExtUtils::MakeMaker)
and make rpmlint happy :) and I'll approve.
+ source files match upstream:
34740f5b944d42760816288f727f98fb CGI-Session-4.20.tar.gz
34740f5b944d42760816288f727f98fb ../CGI-Session-4.20.tar.gz
+ package meets naming and versioning guidelines.
+ specfile is properly named, is cleanly written and uses macros consistently.
+ dist tag is present.
+ build root is correct.
+ license field matches the actual license.
+ license is open source-compatible. License text not included upstream.
+ latest version is being packaged.
O BuildRequires are proper. (needs a br on perl(ExtUtils::MakeMaker))
+ %clean is present.
+ package installs properly
X rpmlint is (almost) silent:
[build at zeus perl-CGI-Session]$ rpmlint perl-CGI-Session-4.20-1.fc6.src.rpm
W: perl-CGI-Session mixed-use-of-spaces-and-tabs (spaces: line 1, tab: line 12)
+ final provides and requires are sane:
== provides
perl(CGI::Session)
perl(CGI::Session::Driver)
perl(CGI::Session::Driver::DBI)
perl(CGI::Session::Driver::db_file) = 4.20
perl(CGI::Session::Driver::file)
perl(CGI::Session::Driver::mysql)
perl(CGI::Session::Driver::postgresql)
perl(CGI::Session::Driver::sqlite)
perl(CGI::Session::ErrorHandler)
perl(CGI::Session::ID::incr)
perl(CGI::Session::ID::md5)
perl(CGI::Session::ID::static)
perl(CGI::Session::Serialize::default)
perl(CGI::Session::Serialize::freezethaw)
perl(CGI::Session::Serialize::json)
perl(CGI::Session::Serialize::storable)
perl(CGI::Session::Serialize::yaml)
perl(CGI::Session::Test::Default)
perl(CGI::Session::Tutorial)
perl(OverloadedObjectClass)
perl(SimpleObjectClass)
perl-CGI-Session = 4.20-1.fc6
== requires
perl(:MODULE_COMPAT_5.8.8)
perl(CGI::Session::Driver)
perl(CGI::Session::Driver::DBI)
perl(CGI::Session::ErrorHandler)
perl(Carp)
perl(Class::Struct)
perl(DBD::Pg)
perl(DBI)
perl(DB_File)
perl(Data::Dumper)
perl(Digest::MD5)
perl(Fcntl)
perl(File::Basename)
perl(File::Spec)
perl(FreezeThaw)
perl(Safe)
perl(Scalar::Util)
perl(Storable)
perl(Test::More)
perl(base)
perl(overload)
perl(strict)
perl(vars)
+ %check is present and all tests pass:
All tests successful, 7 tests skipped.
Files=46, Tests=1295, 47 wallclock secs ( 9.29 cusr + 1.88 csys = 11.17 CPU)
+ no shared libraries are added to the regular linker search paths.
+ owns the directories it creates.
+ doesn't own any directories it shouldn't.
+ no duplicates in %files.
+ file permissions are appropriate.
+ no scriptlets present.
+ code, not content.
+ documentation is small, so no -docs subpackage is necessary.
+ %docs are not necessary for the proper functioning of the package.
+ no headers.
+ no pkgconfig files.
+ no libtool .la droppings.
+ not a GUI app.
--
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.
More information about the Fedora-package-review
mailing list