[Bug 232585] Review Request: telescope_server - Opensource Telescope control servers to interface with stellarium

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: telescope_server - Opensource Telescope control servers to interface with stellarium


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=232585


kevin at tummy.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
         AssignedTo|nobody at fedoraproject.org    |kevin at tummy.com
               Flag|                            |fedora-review?




------- Additional Comments From kevin at tummy.com  2007-03-20 01:31 EST -------
OK - Spec file matches base package name.
OK - Spec has consistant macro usage.
OK - Meets Packaging Guidelines.
OK - License (GPL)
OK - License field in spec matches
OK - License file included in package
OK - Spec in American English
OK - Spec is legible.
OK - Sources match upstream md5sum:
svn checkout diff matches.
OK - BuildRequires correct
OK - Package has %defattr and permissions on files is good.
OK - Package has a correct %clean section.
OK - Package has correct buildroot
OK - Package is code or permissible content.
OK - Packages %doc files don't affect runtime.
OK - Package has rm -rf RPM_BUILD_ROOT at top of %install

OK - Package compiles and builds on at least one arch.
OK - Package has no duplicate files in %files.
OK - Package doesn't own any directories other packages own.
OK - Package owns all the directories it creates.
See below - No rpmlint output.
OK - final provides and requires are sane

SHOULD Items:

OK - Should build in mock.
OK - Should build on all supported archs
OK - Should have dist tag
OK - Should package latest version

Issues:

1. You should not use a _ in the name... from the PackageNamingGuidelines:
"When naming packages for Fedora, the maintainer should use the dash '-' as the
delimiter for name parts. The maintainer should NOT use an underscore '_',
a plus '+', or a period '.' as a delimiter." There are some exceptions after that,
do you think this meets one of those? I think it would be nice to use a -

2. The included source seems to already contain the compiled binaries, so the
build says: "make: Nothing to be done for `all'." and uses the included binaries.
Please make a clean source checkout and make sure there are no included binaries.

3. rpmlint says:
E: telescope-server-debuginfo empty-debuginfo-package

Looks like the Makefile strips the binaries. Can you patch it not to do so?
LDFLAGS = -s

Also, can you confirm it's using RPM_OPT_FLAGS for compiling?

4. Is the versioning right here?
Shouldn't it be:
0-0.1.20070315svn.%{?dist}
Then the next version for any package change would be:
0-0.2.20070315svn.%{?dist}


-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.