[Bug 232747] Review Request: perl-Net-CUPS - Perl bindings to the CUPS C API Interface

bugzilla at redhat.com bugzilla at redhat.com
Wed Mar 21 04:21:16 UTC 2007


Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: perl-Net-CUPS - Perl bindings to the CUPS C API Interface
Alias: perl-Net-CUPS

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=232747


panemade at gmail.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|fedora-review?              |fedora-review+




------- Additional Comments From panemade at gmail.com  2007-03-21 00:21 EST -------
Review:
+ package builds in mock (development i386).
+ rpmlint is silent for SRPM and for RPM.
+ source files match upstream url
236f38f0dc33163ad5dbb0181e4bf7c4  Net-CUPS-0.51.tar.gz
+ package meets naming and packaging guidelines.
+ specfile is properly named, is cleanly written
+ Spec file is written in American English.
+ Spec file is legible.
+ dist tag is present.
+ build root is correct.
+ license is open source-compatible.
+ License text is included in package.
+ %doc is present.
+ BuildRequires are proper.
+ %clean is present.
+ package installed properly.
+ Macro use appears rather consistent.
+ Package contains code, not content.
+ no headers or static libraries.
+ no .pc file present.
+ no -devel subpackage
+ no .la files.
+ no translations are available
+ Does owns the directories it creates.
+ no scriptlets present.
+ no duplicates in %files.
+ file permissions are appropriate.
+ make test
PERL_DL_NONLAZY=1 /usr/bin/perl "-MExtUtils::Command::MM" "-e" "test_harness(0,
'blib/lib', 'blib/arch')" t/*.t
t/01_use.....ok
t/02_cups....ok
All tests successful.
Files=2, Tests=12,  1 wallclock secs ( 0.12 cusr +  0.02 csys =  0.14 CPU)

+ Provides: CUPS.so perl(Net::CUPS) = 0.51 perl(Net::CUPS::Destination) = 0.51
perl(Net::CUPS::IPP) = 0.51 perl(Net::CUPS::PPD) = 0.51

APPROVED.
         

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.




More information about the Fedora-package-review mailing list