[Bug 233244] Review Request: libiptcdata - IPTC Metadata library

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: libiptcdata - IPTC Metadata library


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=233244


mtasaka at ioa.s.u-tokyo.ac.jp changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |mtasaka at ioa.s.u-tokyo.ac.jp




------- Additional Comments From mtasaka at ioa.s.u-tokyo.ac.jp  2007-03-21 05:49 EST -------
First impression
* URL
  - For URL, please use:
    http://libiptcdata.sourceforge.net/

* Python directory
  - For python sitelib/arch directory, please refer to
    http://fedoraproject.org/wiki/Packaging/Python

* Release specific dependency
  - Usually, the dependency for main (and other) package
    must be release number specific.
    http://fedoraproject.org/wiki/Packaging/ReviewGuidelines

* Timestamps
  - Please keep timestamps on the files which are not created
    at build time (i.e. which are included in the original
    tarball and not modified at build time) (for example,
    header files in -devel package).

    For this package, the following works.
------------------------------------------------
make DESTDIR=%{buildroot} INSTALL="%{__install} -c -p" install
------------------------------------------------

* Documentation
  - File "INSTALL" should not be needed. This is for
    who want to install this package by themselves.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.