[Bug 231736] Review Request: perl-FileHandle-Fmode - FileHandle::Fmode Perl module

bugzilla at redhat.com bugzilla at redhat.com
Wed Mar 21 15:26:45 UTC 2007


Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: perl-FileHandle-Fmode - FileHandle::Fmode Perl module


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=231736





------- Additional Comments From cweyl at alumni.drew.edu  2007-03-21 11:26 EST -------
Two rpmlint end-of-line encoding warnings; correct those and I'll approve.

+ source files match upstream:
 1d0c629d8e4138fc753757ad41e69d5d  FileHandle-Fmode-0.09.tar.gz
 1d0c629d8e4138fc753757ad41e69d5d  ../FileHandle-Fmode-0.09.tar.gz
+ package meets naming and versioning guidelines.
+ specfile is properly named, is cleanly written and uses macros consistently.
+ dist tag is present.
+ build root is correct.
+ license field matches the actual license.
+ license is open source-compatible.  License text not included upstream.
+ latest version is being packaged.
+ BuildRequires are proper.
+ compiler flags are appropriate.
+ %clean is present.
+ package installs properly
+ debuginfo package looks complete.
x rpmlint is silent.
+ final provides and requires are sane:
** perl-FileHandle-Fmode-0.09-1.fc6.x86_64.rpm
== rpmlint
W: perl-FileHandle-Fmode wrong-file-end-of-line-encoding
/usr/share/doc/perl-FileHandle-Fmode-0.09/CHANGES
W: perl-FileHandle-Fmode wrong-file-end-of-line-encoding
/usr/share/doc/perl-FileHandle-Fmode-0.09/README
== provides
Fmode.so()(64bit)  
perl(FileHandle::Fmode)  
perl-FileHandle-Fmode = 0.09-1.fc6
== requires
libc.so.6()(64bit)  
libc.so.6(GLIBC_2.2.5)(64bit)  
perl(:MODULE_COMPAT_5.8.8)  
perl(DynaLoader)  
perl(Exporter)  
perl(Fcntl)  
perl(strict)  
rpmlib(CompressedFileNames) <= 3.0.4-1
rpmlib(PayloadFilesHavePrefix) <= 4.0-1
rtld(GNU_HASH)  
** perl-FileHandle-Fmode-debuginfo-0.09-1.fc6.x86_64.rpm
== rpmlint
== provides
Fmode.so.debug()(64bit)  
perl-FileHandle-Fmode-debuginfo = 0.09-1.fc6
== requires
rpmlib(CompressedFileNames) <= 3.0.4-1
rpmlib(PayloadFilesHavePrefix) <= 4.0-1
+ %check is present and all tests pass:
All tests successful.
Files=2, Tests=104,  0 wallclock secs ( 0.05 cusr +  0.03 csys =  0.08 CPU)
+ no shared libraries are added to the regular linker search paths.
+ owns the directories it creates.
+ doesn't own any directories it shouldn't.
+ no duplicates in %files.
+ file permissions are appropriate.
+ no scriptlets present.
+ code, not content.
+ documentation is small, so no -docs subpackage is necessary.
+ %docs are not necessary for the proper functioning of the package.
+ no headers.
+ no pkgconfig files.
+ no libtool .la droppings.
+ not a GUI app.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.




More information about the Fedora-package-review mailing list