[Bug 232617] Review Request: perl-Sys-SigAction - Perl extension for Consistent Signal Handling

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: perl-Sys-SigAction - Perl extension for Consistent Signal Handling
Alias: perl-Sys-SigAction

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=232617


panemade at gmail.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|fedora-review?              |fedora-review+




------- Additional Comments From panemade at gmail.com  2007-03-23 02:58 EST -------
Review:
+ package builds in mock (development i386).
+ rpmlint is silent for SRPM and for RPM.
+ source files match upstream url
ba520c175ea5c41950f53e60801da476  Sys-SigAction-0.10.tar.gz
+ package meets naming and packaging guidelines.
+ specfile is properly named, is cleanly written
+ Spec file is written in American English.
+ Spec file is legible.
+ dist tag is present.
+ build root is correct.
+ license is open source-compatible.
+ License text is included in package.
+ %doc is present.
+ BuildRequires are proper.
+ %clean is present.
+ package installed properly.
+ Macro use appears rather consistent.
+ Package contains code, not content.
+ no headers or static libraries.
+ no .pc file present.
+ no -devel subpackage
+ no .la files.
+ no translations are available
+ Does owns the directories it creates.
+ no scriptlets present.
+ no duplicates in %files.
+ file permissions are appropriate.
+ make test
PERL_DL_NONLAZY=1 /usr/bin/perl "-MExtUtils::Command::MM" "-e" "test_harness(0,
'blib/lib', 'blib/arch')" t/*.t
t/mask.......ok
t/name.......ok
t/nested.....ok
t/number.....ok
t/safe.......

      NOTE: Setting safe=>1... with masked signals does not seem to work.
      The problem is that the masked signals are not masked, but when
      safe=>0 they are.  See mask.t for how we could try it.

      If you have an application for safe=>1 and can come up with
      a test that works in the context of this module's installation
      please send me an update. To safe.t that tests it.

      Lincoln

ok
t/timeout....ok
All tests successful.
Files=6, Tests=33,  6 wallclock secs ( 1.16 cusr +  0.08 csys =  1.24 CPU)

+ Provides: perl(Sys::SigAction) = 0.10
APPROVED.


-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.