[Bug 219097] Review Request: vdr-wapd - WAP daemon for VDR

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: vdr-wapd - WAP daemon for VDR


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=219097





------- Additional Comments From fedora at leemhuis.info  2007-03-24 12:27 EST -------
Note: This is a review without testing the runtime capabilities -- I don't have
the hardware and software setup to test it at hand, so I'll focus on the package
itself. I'm confident it'll work, as it is in a nother repo for some time
already. If someone has a problems with it speak up, but testing runtime
capabilities is afaics no must (it's only a should).

 rpmlint
E: vdr-wapd non-standard-uid /etc/vdr/plugins/wapaccess vdr
E: vdr-wapd non-readable /etc/vdr/plugins/wapaccess 0640
E: vdr-wapd non-standard-uid /etc/vdr/plugins/waphosts vdr
E: vdr-wapd non-readable /etc/vdr/plugins/waphosts 0640
 acceptable in this case afaics.

 package meets naming and versioning guidelines.
 specfile is properly named, is cleanly written and uses macros consistently.
 dist tag is present.
 build root is correct.
      %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n)
 license field matches the actual license.
 license is open source-compatible. 
 BuildRequires are proper.
 %clean is present.
 package builds in mock.
 package installs properly
 debuginfo package looks complete.
 final provides and requires are sane:

 owns the directories it creates.
 doesn't own any directories it shouldn't.
 no duplicates in %files.
 no scriptlets present.
 code, not content.
 documentation is small, so no -docs subpackage is necessary.
 %docs are not necessary for the proper functioning of the package.
 no headers.
 no pkgconfig files.
 no libtool .la droppings.
 not a GUI app.

Problems: 
 * upstream not reachable atm; did it move?

 * the uid stuff rpmlint complains about is acceptable, but shouldn't it
"Requires(pre): vdr", to make sure the users gets created before installation of
the plug-in?

Notes:
 * regarding the selinux comment in vdr-wapd-proxy.conf -- isn't there a
possibility to make it "simply work" without offloading configuration to the user?

 * "BuildRequires:  sed >= 3.9.5" -- sed is in the Exceptions list in the
Packaging Guidelines, so this should not be needed afaics

 * Regarding the summary: would be nice to have a slightly more verbose one, as
probably many users won#t know what a "WAP daemon" is or does

 * what's that "LIBDIR=." in the makefile? Looks suspicious; a comment might be
nice, if there is a good reasons for this (I suppose there is)

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.