[Bug 190040] Review Request: hydrogen - Advanced drum machine

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: hydrogen - Advanced drum machine


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=190040





------- Additional Comments From opensource at till.name  2007-03-26 00:19 EST -------



(In reply to comment #12)
> (In reply to comment #8) 
> > NEEDSWORK:
> > 
> > Source0 should be a full URL. It should be
> > http://dl.sf.net/sourceforge/hydrogen/hydrogen-0.9.3.tar.gz
> 
> I've updated this to the easynews link.

Recommended is:
http://downloads.sourceforge.net/%{name}/%{name}-%{version}.tar.gz
see:
http://fedoraproject.org/wiki/Packaging/SourceURL#head-e27982f18a3bfd26b5b6ecbee113d2d8f3f006f2

> > The update-desktop-database doesn't match what's in ScriptletSnippets, and
> > according to ScriptletSnippets, you only need it if there's a MimeType key.
> 
> Fixed (it does have a MimeType key).
> 
> Here are the updated bits:
> 
> Spec URL: http://people.redhat.com/green/FE/FC5/hydrogen.spec
> SRPM URL: http://people.redhat.com/green/FE/FC5/hydrogen-0.9.3-5.src.rpm

The changelog says:
- Remove post/postun scriptlets.

Because the .desktop files MimeType entry you need the scriptlets from:
http://fedoraproject.org/wiki/Packaging/ScriptletSnippets#head-de6770dd9867fcd085a73a4700f6bcd0d10294ef


-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.