[Bug 233695] Review Request: Pyclutter - Python modules that allow you to use the Clutter toolkit

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: Pyclutter - Python modules that allow you to use the Clutter toolkit


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=233695





------- Additional Comments From mtasaka at ioa.s.u-tokyo.ac.jp  2007-03-28 13:13 EST -------
Well:
The reason why I switched backed to fedora-review? is that
at least the following issues should be fixed before committing
to Fedora.

* Python releated dependency
  - Well, for python related packages, the dependency for it
    should be checked with some more process.
    Usually, this can be checked by what modules the scripts
    in the package try to import.

    Example:
    /usr/lib/python2.5/site-packages/clutter/__init__.py contains the
    line:
-------------------------------------------------------------
     8
     9  # use the pygtk module lazy loading stuff
    10  from gtk._lazyutils import LazyNamespace, LazyModule
    11  
-------------------------------------------------------------
    This means that this package needs "Requires: pygtk2".
    pygtk2 has "/usr/lib/python2.5/site-packages/gtk-2.0/gtk/_lazyutils.py"

* Dependency for -devel packge
  - Again check this. For this, you must check what files
    the header files in this -devel try to include (i.e.
    search "#include" words)

    For pyclutter.h:
-------------------------------------------------------------
     7
     8  #include <glib.h>
     9  
    10  #define NO_IMPORT_PYGOBJECT
    11  #include <pygobject.h>
    12  #include <Python.h>
    13  #include <clutter/clutter.h>
    14  #include <clutter/clutter-feature.h>
    15  
------------------------------------------------------------

* %defatter
  - Please unify. i.e. Use %defattr(-,root,root,-) also to -devel
    package.

* Redundant Requires/BuildRequires
  - Please remove redundant (Build)Requires unless you have special
    reason to leave them.

    python-devel <- this is required by pycairo-devel
                 <- and pycairo-devel is required by pygtk2-devel
    glib2-devel  <- this is required by gtk2-devel
    pygobject2-devel <- this is required by pygtk2-devel

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.