[Bug 233845] Review Request: perl-XML-XPathEngine - Re-usable XPath engine for DOM-like trees

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: perl-XML-XPathEngine - Re-usable XPath engine for DOM-like trees
Alias: perl-XML-XPathEngine

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=233845


panemade at gmail.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|fedora-review?              |fedora-review+




------- Additional Comments From panemade at gmail.com  2007-03-29 03:15 EST -------
Review:
+ package builds in mock (development i386).
+ rpmlint is silent for SRPM and for RPM.
+ source files match upstream url
225f53d420d4fca50cd9d18b877780d6  XML-XPathEngine-0.08.tar.gz
+ package meets naming and packaging guidelines.
+ specfile is properly named, is cleanly written
+ Spec file is written in American English.
+ Spec file is legible.
+ dist tag is present.
+ build root is correct.
+ license is open source-compatible.
+ License text is included in package.
+ %doc is present.
+ BuildRequires are proper.
+ %clean is present.
+ package installed properly.
+ Macro use appears rather consistent.
+ Package contains code, not content.
+ no headers or static libraries.
+ no .pc file present.
+ no -devel subpackage
+ no .la files.
+ no translations are available
+ Does owns the directories it creates.
+ no scriptlets present.
+ no duplicates in %files.
+ file permissions are appropriate.
+ make test
PERL_DL_NONLAZY=1 /usr/bin/perl "-MExtUtils::Command::MM" "-e" "test_harness(0,
'blib/lib', 'blib/arch')" t/*.t
t/00-load.........# Testing XML::XPathEngine 0.08, Perl 5.008007, /usr/bin/perl
ok
t/01_basic........ok
t/pod-coverage....ok
t/pod.............ok
All tests successful.
Files=4, Tests=27,  1 wallclock secs ( 0.47 cusr +  0.05 csys =  0.52 CPU)
+ Provides: perl(XML::XPathEngine) = 0.08 perl(XML::XPathEngine::Boolean)
perl(XML::XPathEngine::Expr) perl(XML::XPathEngine::Function)
perl(XML::XPathEngine::Literal) perl(XML::XPathEngine::LocationPath)
perl(XML::XPathEngine::NodeSet) perl(XML::XPathEngine::Number)
perl(XML::XPathEngine::Root) perl(XML::XPathEngine::Step)
perl(XML::XPathEngine::Variable)

APPROVED.


-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.