[Bug 225931] Merge Review: jakarta-commons-lang

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Merge Review: jakarta-commons-lang


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=225931





------- Additional Comments From pcheung at redhat.com  2007-03-29 15:49 EST -------
(In reply to comment #3)
...
> * skim the summary and description for typos, etc.
> X utilities is spelled wrong
> 
Fixed
> * rpmlint on <this package>.srpm gives no output
>  - justify warnings if you think they shouldn't be there
> rpmlint jakarta-commons-lang-2.1-6jpp.1.fc7.src.rpm
> W: jakarta-commons-lang non-standard-group Development/Libraries/Java
> W: jakarta-commons-lang strange-permission jakarta-commons-lang-notarget.patch
0660
> W: jakarta-commons-lang strange-permission jakarta-commons-lang.spec 0640
> W: jakarta-commons-lang strange-permission commons-lang-2.1-src.tar.gz 0660
> 
> X please fix file permissions
> 
Fixed
>  - the following packages don't need to be listed in BuildRequires:
>    bash
>    bzip2
>    coreutils
>    cpio
>    diffutils
>    fedora-release (and/or redhat-release)
>    gcc
>    gcc-c++
>    gzip
>    make
>    patch
>    perl
>    redhat-rpm-config
>    rpm-build
>    sed
>    tar
>    unzip
>    which
> X sed and perl do not need to be included
Got rid of both sed and perl
> 
> * summary should be a short and concise description of the package
> X summary just states the package name
> 
Updated

Updated spec file and srpm at the same location.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.