[Bug 226387] Merge Review: samba

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Merge Review: samba


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=226387





------- Additional Comments From dmitry at butskoy.name  2007-03-30 10:56 EST -------
Schema:
> And no, we don't own the directory.
Hmmm, I see "%dir %{_sysconfdir}/openldap/schema" in the "samba" package's
%files section...

Well, maybe just mark the schema file as "%config(noreplace)" ? Openldap does it
for its schema files.


Docs:
> the user can go on the website 
"Conflicts: area-without-internet-access" ? ;)

> we can't split everything in down
I do not mean "split samba-doc to several subpackages", I mean "do not cause
user to install 13.5Mb package just to get some of the small files". Consider
autofs/, libsmbclient/, misc/, printer-accounting/, printer/, registry/
directories, for example. Unlike surely LDAP/, htmldocs/ (swat :) ) and *.pdf .

BTW, "COPYING" IMHO should be in the main sub-package (i.e. in "samba").

Generally, the recommendation "move big documentation to separate sub-package"
does dot mean "move all the documentation". Move just _really big_ stuff to it.


Migration:
> it is absolutely not correct that on of the scripts stop any other just
> to do the migration
I mean that each script does migration of its _own part_ of data. Certainly, if
it is possible (i.e. no situation where two different daemons have simultaneous
access to some *.tdb file).

Well, since initscript idea is not suitable, maybe consider triggers? It seems that:

%triggerun common -- samba-common < 3.0.24
stop_all_running_daemons and touch_its_var_lock
do_the_migration

cause migration to be performed before any "samba-common < 3.0.24" uninstall,
which looks more clean than "Requires(pre):" .

(BTW, if I'm not wrong, according to dependences, old "samba" is removed first,
then old "samba-common", ..., then new "samba-common" installed, then "samba".
It seems that if we use "%triggerpostun", not "%triggerun", then
"stop_all_running_daemons and touch_its_var_lock" is not needed at all...)

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.