[Bug 226658] Merge Review: xsane

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Merge Review: xsane


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=226658


bugzilla at redhat.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Severity|normal                      |medium




------- Additional Comments From nphilipp at redhat.com  2007-03-30 11:31 EST -------
(In reply to comment #1)
> Just checked this package in Mock build environment and created patch to SPEC

> -Summary: An X Window System front-end for the SANE scanner interface.
> +Summary: An X Window System front-end for the SANE scanner interface

"X Window System front-end for the SANE scanner interface"

> -Buildroot: %{_tmppath}/%{name}-buildroot
> +Buildroot: %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n)

OK

>  %package gimp
> -Summary: A GIMP plug-in which provides the SANE scanner interface.
> +Summary: A GIMP plug-in which provides the SANE scanner interface

"GIMP plug-in providing the SANE scanner interface"

>  %prep
> -rm -rf %{buildroot}

OK

> -%{_sysconfdir}/gimp
> -%{_sysconfdir}/gimp/plugins.d
> -%config %{_sysconfdir}/gimp/plugins.d/xsane.conf
> +%dir %{_sysconfdir}/gimp
> +%dir %{_sysconfdir}/gimp/plugins.d
> +%config(noreplace) %{_sysconfdir}/gimp/plugins.d/xsane.conf

OK

>  * Mon Jul 26 1999 Tim Powers <timp at redhat.com>
>  - update to 0.30
> -- added %defattr
> +- added %%defattr

OK

> Also you may need to add following line to SPEC for desktop-file-install
>         --remove-category Application                           \
> Neccesary for warning coming in build.log

Please explain.

> Then i even saw rpmlint output is not silent on RPM. It gave me
> I: xsane checking
> W: xsane rpm-buildroot-usage %build %configure --with-install-root=%{buildroot}
> $RPM_BUILD_ROOT should not be touched during %build or %prep stage, as it
> will break short circuiting.
> 
> W: xsane rpm-buildroot-usage %build %configure --with-install-root=%{buildroot}
> --disable-gimp
> $RPM_BUILD_ROOT should not be touched during %build or %prep stage, as it
> will break short circuiting.

I've removed --with-install-root=... from the configure calls (let's hope it
doesn't break anything).

> Also Mock build.log is gave me following messages
> acinclude.m4:8: warning: underquoted definition of AM_PATH_GTK2
> acinclude.m4:8:   run info '(automake)Extending aclocal'
> acinclude.m4:8:   or see
> http://sources.redhat.com/automake/automake.html#Extending-aclocal
> m4/gettext.m4:60: the serial number must appear before any macro definition
> m4/gettext.m4:83: the serial number must appear before any macro definition

AFAIK that's from other pkgs' files in /usr/share/aclocal.

> 
> AND
> sed: can't read ./intl/po2tbl.sed.in: No such file or directory

I don't know about this one and why it happens.

> Can you please look at these things?

hwbrowser-0.993-2 is building with the changes above.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.