[Bug 237742] Review Request: perl-Text-SimpleTable - Simple Eyecandy ASCII Tables

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: perl-Text-SimpleTable - Simple Eyecandy ASCII Tables
Alias: Text-SimpleTable

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=237742





------- Additional Comments From cweyl at alumni.drew.edu  2007-04-30 23:21 EST -------
(In reply to comment #3)
> (In reply to comment #2)
> > Though Pod-tests are not really important, this doesn't necessarily provide
> > trust into this package's quality.
>  
> Well, IMHO any failure in %check is a blocker until it is known why the test
> fails.  The tests are there for a reason.  If the test reveals a bug (in the
> software package, not the buildsystem or Fedora) - and it is deemed minor to the
> operation of the package, it should be reported upstream and the test failure
> should be commented in the spec file as a known problem.
> 
> If the failure is a bug in the test itself or the test is invalid, the test
> should be removed (with a proper comment in the spec file) or fixed.  It should
> also be reported upstream.
> 
> Blindly ignoring failures is never a good thing.

Oh I agree -- and this isn't just ignoring it.  The "falure" this test reports
is that the new() method isn't documented...  These tests are development aids,
a easy way for the developer to check to make sure they documented everything. 
A "fail" here doesn't say anything about the code, or its quality -- aside from
any conclusions we may want to draw from it -- just that one or more methods
have no documentation, and the other ones have (potentially bad) documentation.

It's important to note that when run by default, as _upstream_ defines default,
these tests are skipped.  By not defining TEST_POD=1, we're just running the
suite as intended.

/me hands back the soapbox :)

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.