[Bug 235960] Review Request: perl-Data-Visitor - Visitor style traversal of Perl data structures

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: perl-Data-Visitor - Visitor style traversal of Perl data structures
Alias: perl-Data-Visitor

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=235960


panemade at gmail.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|fedora-review?              |fedora-review+




------- Additional Comments From panemade at gmail.com  2007-05-01 23:54 EST -------
Review:
+ package builds in mock (development i386).
+ rpmlint is silent for SRPM and for RPM.
+ source files match upstream url
d8b5c458439698187db0bfee672044ef  Data-Visitor-0.05.tar.gz
+ package meets naming and packaging guidelines.
+ specfile is properly named, is cleanly written
+ Spec file is written in American English.
+ Spec file is legible.
+ dist tag is present.
+ build root is correct.
+ license is open source-compatible.
+ License text is included in package.
+ %doc is present.
+ BuildRequires are proper.
+ %clean is present.
+ package installed properly.
+ Macro use appears rather consistent.
+ Package contains code, not content.
+ no headers or static libraries.
+ no .pc file present.
+ no -devel subpackage
+ no .la files.
+ no translations are available
+ Does owns the directories it creates.
+ no scriptlets present.
+ no duplicates in %files.
+ file permissions are appropriate.
+ make test outputs
t/base.................ok
t/bugs.................ok
t/callback.............ok
t/callback_aliasing....ok
t/circular_refs........ok
t/globs................ok
All tests successful.
Files=6, Tests=64,  1 wallclock secs ( 0.30 cusr +  0.08 csys =  0.38 CPU)
+ Provides: perl(Data::Visitor) = 0.05 perl(Data::Visitor::Callback)

APPROVED.


-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.