[Bug 235815] Review Request: freetennis - Tennis simulation game

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: freetennis - Tennis simulation game


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=235815





------- Additional Comments From dev at nigelj.com  2007-05-02 16:12 EST -------
(In reply to comment #2)
> Initial list with some things to fix after a quick initial look.
> 
> - The main "%files" is missing a %defattr, this should be added as the first
> line after %files
> 
> - %files-data can be written mich shorter, it can (and should be) as simple as:
> 
> %files data
> %defattr(-,root,root,-)
> %doc COPYING CHANGES.txt AUTHORS
> %{_datadir}/%{name}
> 
>   Also notice that %defattr is the first line after %files data, putting 
>   %defattr at the end has no effects as %defattr is only applied to files listed
>   below it, but read on...
Okay shall do...
> - However since the data is in the same upstream tarbal as the sources, and
>   this cannot be in a seperate srpm there is no use (what so ever) in having
>   it in a subpackage, so just completely remove the data sub-package,
>   and add the single line "%{_datadir}/%{name}" to the main %files list
> 
Right, I'll do that (I'm going to wait until I can convince camlimages to build
in mock though)
> - Please add an icon, just take any suitable graphics included and resize / edit
>   it as nescesarry then install it under /usr/share/icons/hicolor/<size>/apps
>   and add the necessary scripts to update the icon-cache. (See scriptlets wiki
>   page)
Okay
> 
> 
> p.s. Do you still need a sponsor? Once this and the deps have been reviewed I
> can sponsor you if needed.
> 
Nope, I'm in cvsextras already (was sponsored by Kevin with package windowlab)
and removed the FE-NEEDSPONSOR stuff already (anyway, how could I have approved
your other package? ;))
> 



-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.