[Bug 235804] Review Request: ocaml-SDL - OCaml bindings for SDL

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: ocaml-SDL - OCaml bindings for SDL


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=235804


j.w.r.degoede at hhs.nl changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|nobody at fedoraproject.org    |j.w.r.degoede at hhs.nl
               Flag|                            |fedora-review?




------- Additional Comments From j.w.r.degoede at hhs.nl  2007-05-03 08:30 EST -------
MUST:
=====
* rpmlint output is clean
* Package and spec file named appropriately
* Packaged according to packaging guidelines
* License ok
* spec file is legible and in Am. English.
* Source matches upstream
* Compiles and builds on devel i386
* BR: ok
* No locales
0 No shared libraries, ldconfig not needed
* Not relocatable
* Package owns / or requires all dirs
* No duplicate files & Permissions ok
* %clean & macro usage OK
* Contains code only
* %doc does not affect runtime, and isn't large enough to warrent a sub package
* -devel package as needed
* no .desktop file needed

MUST FIX
========
* Change Source0 from:
http://optusnet.dl.sourceforge.net/sourceforge/ocamlsdl/ocamlsdl-0.7.2.tar.gz
  to the generic sf download url, and use %{version}:
http://downloads.sourceforge.net/ocamlsdl/ocamlsdl-%{version}.tar.gz
* main package must require ocaml for /usr/lib/ocaml/stublibs dir ownership
* remove the unnecessary ldconfig %post(un) scripts, this are not normally
  libs and since they are not installed in a path searched by ldconfig, calling
  ldconfig is useless.

Should Fix
==========
* Stop the obfuscated double %setup usage, instead of the 2 lines you can just
write: "%setup -q -n ocamlsdl-%{version} -a 1"

* No need to write:
  %dir %{_libdir}/ocaml/sdl

  %{_libdir}/ocaml/sdl/*.*a
  %{_libdir}/ocaml/sdl/*.cmi
  %{_libdir}/ocaml/sdl/*.cmx
  Instead you can just write:
  %{_libdir}/ocaml/sdl
  If there were files there which you wouldn't include with the wildcards,
  then rpmbuild would refuse to build the rpm as there would be files in
  $RPM_BUILD_ROOT, which aren't listed under any %files.

* also please always make all your %files entries like this:
  %files
  %defattr(....)
  %doc ...
  <other files and dirs>


-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.